May 2024

1 commit
Fix assorted bugs related to identity column in partitioned tables
7 May 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #252 of 2 reviewers saw the final version

The seven-file patch in #25 matches the committed implementation and tests; differences are rebase offsets and spacing before a test table's opening parenthesis. The proposed defensive tuple check was not added.

  • Dmitry Dolgovsaw the final versiontrailerIn #27 and #29, he confirmed coverage of the reported failures and examined tuple validity, repeated ancestor lookup, and attribute-mapping safety.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Feb 2024

1 commit
Remove extra check_stack_depth() from dropconstraint_internal()
21 Feb 2024Alexander Korotkovmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

The deletion of the duplicate check_stack_depth() call and its comment in dropconstraint_internal() follows Ashutosh's report #17 and Alexander Lakhin's confirmation #18. Alexander Korotkov announced the removal in #19; no attachment contains it.

  • Ashutosh Bapatsaw the final versionLLM analysis, 98% sureHe identified the consecutive duplicate checks and proposed removing the second in #17, which is exactly the committed change.
  • Alexander Lakhinsaw the final versionLLM analysis, 98% sureHe confirmed the duplicate protection and explained how overlapping changes introduced it in #18.

Jan 2024

4 commits
Support identity columns in partitioned tables
16 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #61 of 1 reviewer saw the final version

The commit consolidates the feature and regression-test components of #6, plus its partition-specific documentation paragraph; independent preparatory patches landed separately and experimental pg_upgrade tests were omitted as requested. Retained code differs through formatting, comments, local declaration placement, and attachment-error wording.

  • Peter Eisentrautsaw the final versiontrailerHe endorsed the initial implementation and manual NOT NULL prerequisite in #5, then approved and committed the completed series in #7, also establishing final coverage as committer.
doc: Add Identity Column section under Data Definition chapter
16 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #6

The identity-column documentation component of #6 was substantially expanded with INSERT examples, ALWAYS/BY DEFAULT explanations, reordered material, and a datatype.sgml cross-reference. The commit explicitly credits Peter Eisentraut alongside sender Ashutosh Bapat as co-author; partition support wording was deferred to the feature commit.

Assert that partition inherits from only one parent in MergeAttributes()
16 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #61 of 1 reviewer saw the final version

Both MergeAttributes() hunks match the independent assertion patch in #6: add Assert(!is_partition) and simplify the subsequent not-null condition and comment. Only base hashes and line offsets differ.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch
doc: Decorate PostgreSQL with productname tag
16 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #61 of 1 reviewer saw the final version

The single ddl.sgml replacement adding productname markup around PostgreSQL exactly matches the independent documentation-style patch in #6.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Dec 2023

1 commit
Fix prologue of get_partition_ancestors()
21 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

The independent get_partition_ancestors() comment patch in #4 landed with rewritten wording describing list order and without its redundant single-ancestor sentence. Peter confirmed committing it in #5.

  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 7 commits

Author
Ashutosh Bapat6
Peter Eisentraut1
Reviewer
Peter Eisentrautcommitter5
Dmitry Dolgov1
Reported by
Alexander Lakhin2
Ashutosh Bapat1
Committer
Peter Eisentraut6
Alexander Korotkov1