Remove obsolete check for TTSOpsVirtual from slot_compile_deform

Started by Xing Guoalmost 3 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t48666
psql -h localhost -U postgres

Built from patchset v1 (message #1), October 06, 2026 at 08:16 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t48666_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t48666_1 && git checkout t48666_1

Patchset v1 (message #1) is on t48666_1

Jump to latest
#1Xing Guo
higuoxing@gmail.com

Hi hackers,

While exploring the JIT support for tuple deforming process, I noticed that
one check for TTSOpsVirtual in slot_compile_deform is obsolete. Since
virtual tuples never need deforming and there's an assertion in
llvm_compile_expr[1]https://github.com/postgres/postgres/blob/0c60e8ba80e03491b028204a19a9dca6d216df91/src/backend/jit/llvm/llvmjit_expr.c#L322. I simply replace it with an assertion in
slot_compile_deform. Patch is attached.

[1]: https://github.com/postgres/postgres/blob/0c60e8ba80e03491b028204a19a9dca6d216df91/src/backend/jit/llvm/llvmjit_expr.c#L322
https://github.com/postgres/postgres/blob/0c60e8ba80e03491b028204a19a9dca6d216df91/src/backend/jit/llvm/llvmjit_expr.c#L322

Best Regards,
Xing

Attachments:

t48666_1
v1-0001-Remove-obsolete-check-for-TTSOpsVirtual-from-slot.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Remove-obsolete-check-for-TTSOpsVirtual-from-slot.patchDownload+2-4