Oct 2024

2 commits
Apply GUC name from central table in more places of guc.c
9 Oct 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #670 of 2 reviewers saw the final version

The complete diff has the same stable patch ID as #67, and the commit credits Peter Smith and Michael Paquier jointly. Michael explicitly selected that version over the additional wrapper split in #68, explaining his decision in #69.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 98% sureAlvaro endorsed the original canonical-name fix and supplied its regression test in #40, before the broader guc.c rework in #67.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% surePeter accepted the mixed-case corrections in #41, before the narrow IntervalStyle change expanded substantially in #67.
Use camel case for "DateStyle" in some error messages
7 Oct 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #663 of 3 reviewers saw the final version

Exactly matches the DateStyle component of the two-patch series #66, including its stable patch ID; the separate IntervalStyle component remained under review.

  • Peter Eisentrautsaw the final versiontrailerPeter supported correcting the case while requesting that quotes remain in #41, and the final DateStyle patch implements that request.
  • Álvaro Herrerasaw the final versiontrailerAlvaro endorsed and carried forward the DateStyle patch in #40, after which its relevant changes were limited to retaining quotes and rebasing.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Sep 2024

2 commits
Unify some error messages to ease work of translators
4 Sep 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #632 of 2 reviewers saw the final version

Takes selected common-message changes from #63, retaining substitutions in xlog.c, variable.c, fd.c and dfmgr.c while dropping changes without translation savings and adding translator comments. The retained work originated in Alvaro's attached patch #40, subsequently revised and carried by Peter Smith.

  • Daniel Gustafssonsaw the final versionLLM analysis, 94% sureDaniel endorsed the common-message component in #53, with subsequent changes consisting of rebasing, a syntax fix, pruning substitutions and translator comments.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Apply more quoting to GUC names in messages
4 Sep 2024Michael Paquiermaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #631 of 1 reviewer saw the final version

Takes the quoting component of #63, adding search_path fixes in contrib/oid2name/oid2name.c and contrib/vacuumlo/vacuumlo.c and adjusting spacing in launcher.c. These committer edits are described in #64; the other series components were handled separately.

  • Michael Paquiersaw the final versioncommittercommitted the patch

May 2024

1 commit
Revise GUC names quoting in messages again
17 May 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #493 of 5 reviewers saw the final version

Combines the documentation and broad quoting components of #49, leaving its case fixes and translation cleanup pending, as confirmed in #56. Differences include rebasing, corrected pg_stat_statements wording and additional commit_ts and SSL expected-output updates.

  • Daniel Gustafssonsaw the final versionLLM analysis, 100% sureDaniel supported accepting the documentation and quoting patches and reviewed the full_page_writes spelling in #52.
  • Tom Lanesaw the final versionLLM analysis, 99% sureTom reviewed the name-and-value quoting in the proposed WAL message and discussed an alternative spelling in #54.
  • Nathan Bossartsaw an earlier versionLLM analysis, 96% sureNathan challenged the conditional rule and advocated quoting every GUC name in #12, a recommendation explicitly adopted in the reworked series #49.
  • Laurenz Albesaw an earlier versionLLM analysis, 88% sureLaurenz proposed always quoting GUC names during the initial design discussion #7, and Peter explicitly cited that recommendation when adopting the uniform rule in #49.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Nov 2023

2 commits
doc: Mention how to use quotes with GUC names in error messages
30 Nov 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #314 of 4 reviewers saw the final version

Takes only the documentation component of #31, with small wording, punctuation and paragraph-placement edits in sources.sgml. The commit credits Alvaro, and #33 explicitly identifies the applied documentation as his work.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom explicitly approved Alvaro's documentation patch in #11, before only light clarification and wording changes.
  • Nathan Bossartsaw the final versionLLM analysis, 99% sureNathan reviewed the proposed wording in #12, identifying the ambiguity of deciding whether a name resembles natural English.
  • Laurenz Albesaw the final versionLLM analysis, 87% sureLaurenz proposed the distinction between underscore-containing identifiers and ordinary-looking names in #7, which the documentation patch codified.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Apply quotes more consistently to GUC names in logs
30 Nov 2023Michael Paquiermaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #317 of 7 reviewers saw the final version

Applies the static quoting cleanup from #31, omitting its DateStyle changes and adding the missing src/test/modules/commit_ts/expected/commit_timestamp_1.out updates. Michael describes both adjustments in #33; the documentation and dynamic-quoting components were separate.

  • Alvaro Herrerasaw the final versionLLM analysis, 100% sureAlvaro endorsed the cleanup in #20, and 8d9978a717 credits his participation.
  • Nathan Bossartsaw the final versionLLM analysis, 95% sureNathan reviewed the governing quoting policy in #12 and is explicitly credited in 8d9978a717.
  • Laurenz Albesaw the final versionLLM analysis, 95% sureLaurenz contributed the conditional-quoting distinction in #7 and is explicitly credited in 8d9978a717.
  • Peter Eisentrautsaw the final versionLLM analysis, 95% surePeter argued for leaving recognizable GUC names unquoted in #6 and is explicitly credited in 8d9978a717.
  • Tom Lanesaw the final versionLLM analysis, 97% sureTom approved the governing policy in #11 and is explicitly credited in 8d9978a717.
  • Daniel Gustafssonsaw the final versionLLM analysis, 93% sureDaniel discussed translation constraints in #3 and #4, and the commit explicitly credits his participation in 8d9978a717.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 7 commits

Author
Peter Smith6
Alvaro Herrera1
Michael Paquier1
Reviewer
Michael Paquiercommitter5
Peter Eisentrautcommitter2
Alvaro Herrera1
Committer
Michael Paquier6
Peter Eisentraut1