Mar 2025

2 commits
Revert "Tidy up locale thread safety in ECPG library."
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1reverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Reverts 8e993bff53 following Masahiko Sawada's build-failure report in #42 and Peter Eisentraut's decision in #43; no revert patch was attached.

  • Masahiko Sawadasaw the final versionLLM analysis, 97% sureReported buildfarm failures and independently reproduced the test_json_parser linker error in #42, prompting the revert.
Tidy up locale thread safety in ECPG library.
28 Mar 2025Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #403 of 3 reviewers saw the final version

Matches the three attachments in #40 combined, including the LC_C_LOCALE guard and sorted build lists, modulo rebasing. The main attachment and commit credit Thomas Munro, whose version Peter forwarded.

  • Peter Eisentrautsaw the final versiontrailerReviewed the architecture and portability details in #26, supplied fixups in #40, and committed the final version as confirmed in #41.
  • Tristan Partinsaw the final versiontrailerSaid the patch looked good and checked the strtod() replacements in #24, after which the retained ECPG implementation received only light changes.
  • Heikki Linnakangassaw the final versiontrailerExamined initialization and strtod() callers and said the patch looked good in #30, before the final rebase and small fixups.

Nov 2024

3 commits
Revert "Blind attempt to fix _configthreadlocale() failures on MinGW."
27 Nov 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1revert
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #351 of 1 reviewer saw the final version

Takes the third patch of #35, restoring _configthreadlocale() failure handling in execute.c and adjusting descriptor.c; its code matches exactly, with revised commit prose.

  • Peter Eisentrautsaw the final versiontrailerRequested restoring the error checks in #31 and endorsed the resulting series in #34, after which only explanatory changes followed.
Require ucrt if using MinGW.
27 Nov 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% suremodified before commitmoderate changesfrom patchset #381 of 1 reviewer saw the final version

Combines Peter Eisentraut's documentation patch in #38, with one wording edit, and Thomas Munro's pg_locale.c cleanup from the second patch in #35. The latest matching submission is the documentation patch, while Thomas supplied the runtime change.

  • Peter Eisentrautsaw the final versiontrailerEndorsed the runtime cleanup series in #34 and supplied the documentation incorporated into the commit in #38.
Remove configure check for _configthreadlocale().
27 Nov 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #351 of 1 reviewer saw the final version

Takes the first patch of #35 unchanged apart from rebasing, removing the _configthreadlocale configure checks and replacing HAVE__CONFIGTHREADLOCALE conditionals with WIN32.

  • Peter Eisentrautsaw the final versiontrailerProposed separating this cleanup in #31 and endorsed the implementation in #34, with no subsequent code changes.

Oct 2024

1 commit
Simplify checking for xlocale.h
1 Oct 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #232 of 2 reviewers saw the final version

Extracts the xlocale.h simplification from #23, adding the missing configure.ac header probe, placing the common include in c.h, and removing redundant includes including src/port/chklocale.c. Peter explicitly describes this extraction and its small corrections in #27.

  • Tristan Partinsaw the final versionLLM analysis, 78% sureGave an overall positive assessment of the containing patch in #24, although his detailed comments focused on strtod() rather than the extracted header cleanup.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 6 commits

Author
Thomas Munro3 LLM5
Reviewer
Peter Eisentrautcommitter5
Heikki Linnakangas1
Tristan Partin1
Committer
Peter Eisentraut3
Thomas Munro3

N LLM means N of the credits come from LLM analysis, not from commit trailers.