Jan 2024

1 commit
Move is_valid_ascii() to ascii.h.
29 Jan 2024Nathan Bossartmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.2REL_15_STABLE15.6
LLM analysis, 100% surelanded as postedfrom patchset #95 of 5 reviewers saw the final version

All four diff hunks across src/common/wchar.c, src/include/mb/pg_wchar.h and src/include/utils/ascii.h match #9 exactly after excluding Git blob identifiers. The commit explicitly credits Jubilee Young as author, although Nathan Bossart sent the revised patch.

  • Tom Lanesaw the final versiontrailerTom examined the original relocation, checked for external callers, favored keeping the helper in a separate header, and endorsed extending the final patch's backpatch scope through v15 #2 #4 #16.
  • John Naylorsaw the final versiontrailerJohn supported the proposed change and explained the original motivation for making the helper inline; subsequent edits only changed its destination and retained the original variable names #7 #9.
  • Andres Freundsaw the final versiontrailerDuring discussion of the final patch, Andres examined the reported compiler-header problem and asked why SIMD headers were especially troublesome, without reporting a test or explicit approval #10.
  • Eric Ridgesaw the final versiontrailerEric explained how bindgen selected incompatible compiler headers, supported removing the exposed dependency, and clarified when pgrx encountered the failure during discussion of the final patch #12 #13.
  • Nathan Bossartsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Jubilee Young1
Reviewer
Andres Freund1
Eric Ridge1
John Naylor1
Nathan Bossartcommitter1
Tom Lane1
Committer
Nathan Bossart1