model-writtenrun 3837 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Jubilee Young reported pgrx build failures caused by SIMD headers exposed through pg_wchar.h and proposed moving is_valid_ascii() into its sole caller's source file, wchar.c #1.
- Tom Lane questioned losing the helper's availability to future callers, while Nathan Bossart proposed a separate header; Tom found no external users in Debian Code Search and supported reducing pg_wchar.h's dependency burden #2 #3 #4.
- Jubilee explained that bindgen could pair libclang with incompatible compiler headers, strengthening the case for a backpatch, and John Naylor supported the change while explaining the helper's original inline design #5 #6 #7.
- Jubilee identified utils/ascii.h as a possible home, and Nathan posted a revision moving the helper and SIMD include there while adding an ascii.h include to wchar.c, preserving the helper for other callers #8 #9.
- Andres Freund questioned why SIMD headers triggered this problem, and Eric Ridge explained bindgen's header-selection failure and confirmed the disruption to pgrx builds #10 #12 #13.
- Nathan left time for objections to backpatching, initially planned coverage through v16, then proposed including v15 so the helper would occupy the same header in every release containing it; Tom agreed #11 #14 #15 #16.
- Nathan committed the revised patch unchanged apart from its rebased context as 97287bdfae, crediting Jubilee as author and backpatching through v15; his final message confirmed completion with no remaining patch work identified #9 #17.