Feb 2025

1 commit
Silence warning in older versions of Valgrind
24 Feb 2025John Naylormaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.5
LLM analysis, 100% suremodified before commitlight changesfrom patchset #991 of 2 reviewers saw the final version

Implements the fallback-helper replacement from #99 in src/include/common/hashfn_unstable.h. Additional cleanup removes now-unnecessary byte swapping, bit-utility includes, and explanations tied to locating the terminator with a bit scan.

  • Anton A. Melnikovsaw the final versionLLM analysis, 100% sureTested #99 and reported no Valgrind errors and improved generated code in #100, before the commit.
  • Tom Lanesaw an earlier versionLLM analysis, 96% sureRejected the Valgrind-only workaround in #87 and requested an unconditional replacement in #88, before the subsequent implementation rework.

Jan 2025

1 commit
Revert "Speed up tail processing when hashing aligned C strings, take two"
29 Jan 2025John Naylormaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3reverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

Reverts a365d9e2e8 rather than applying either attached byte-counting fix. John proposed this course in #90 and confirmed completion in #93.

  • Anton A. Melnikovsaw an earlier versionLLM analysis, 97% sureReported the Valgrind failure in #83 and supported reverting in #92, although #96 later established that he had not tested this specific revert.
  • Tom Lanesaw an earlier versionLLM analysis, 88% sureObjected to suppressing the problematic code under Valgrind in #88, reviewing an earlier repair before the revert and subsequent replacement.

Mar - Apr 2024

5 commits
Teach fasthash_accum to use platform endianness for bytewise loads
6 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surewritten from the discussion, no matching patch

No attachment contains this big-endian fasthash_accum switch, accumulator-reset relocation, and assertion split. It implements the aligned/unaligned equivalence repair discussed in #81 and reported completed in #82.

Speed up tail processing when hashing aligned C strings, take two
6 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #711 of 1 reviewer saw the final version

Returns to Ants Aasma's explicit length-based mask in the first patch of #71, also present in #68, without the second patch's alternative mask calculation. Changes are chiefly helper naming, comments, declarations, and adaptation to the separately committed endianness correction.

  • John Naylorsaw the final versioncommittercommitted the patch
Add macro to disable address safety instrumentation
6 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #781 of 1 reviewer saw the final version

Extracts the complete sanitizer-attribute component of #78, preserving its changes to src/include/c.h and the aligned hashing function unchanged apart from patch context.

  • Jeff Davissaw the final versionLLM analysis, 100% sureRecommended the supported Clang attribute spelling in #77 and explicitly approved the resulting component in #79.
Convert uses of hash_string_pointer to fasthash equivalent
6 Apr 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #781 of 1 reviewer saw the final version

Takes the frontend string-hash conversions from #78, but omits its blkreftable conversion and proposed common .c file and build changes. Following #79, hash_string instead becomes an inline helper in src/include/common/hashfn_unstable.h.

  • Jeff Davissaw the final versionLLM analysis, 99% sureSuggested making hash_string inline in #79, the change adopted for the committed version, which also explicitly credits his review.
Speed up tail processing when hashing aligned C strings
31 Mar 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #781 of 1 reviewer saw the final version

Extracts the aligned-tail component of #78 without substantive changes, including zero_byte_low | (zero_byte_low - 1). The commit credits Ants Aasma and John Naylor, reflecting the original patch and subsequent revisions.

  • John Naylorsaw the final versioncommittercommitted the patch

Feb 2024

3 commits
Fix warnings in cpluspluscheck
8 Feb 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

Directly implements Peter Eisentraut's request in #73 to use size_t for lengths and related variables in hashfn_unstable.h; no matching patch was attached. John confirmed reproduction and the commit in #74.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 98% sureReported cpluspluscheck signedness warnings and proposed the adopted size_t correction in #73, reviewing the committed header before the later tail-processing reworks.
Further cosmetic review of hashfn_unstable.h
6 Feb 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #661 of 1 reviewer saw the final version

Takes the comment-and-naming component of #66, retaining zero_byte_low and the expanded zero-detection explanation. It additionally expands the incremental-interface usage examples and polishes the tail-position comment.

  • Jeff Davissaw the final versionLLM analysis, 100% sureRequested clearer zero-byte documentation in #65 and explicitly approved the resulting comment patch in #67.
Simplify initialization of incremental hash state
6 Feb 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #66

Takes the initialization component of #66, removing the length argument and FH_UNKNOWN_LENGTH while preserving standalone fasthash seed behavior. The additional edits update comments and examples to match.

Jan 2024

2 commits
Add optimized C string hashing
19 Jan 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #574 of 4 reviewers saw the final version

Extracts the complete C-string hashing component of #57, including the namespace.c consumer and aligned/unaligned helpers, with no substantive diff changes. Its authorship credit to Jeff Davis and John Naylor matches the contributions in #36 and #42.

  • Heikki Linnakangassaw the final versionLLM analysis, 100% sureReviewed the final two-patch submission and said it otherwise looked good in #58, and the commit explicitly credits him.
  • jian hesaw the final versionLLM analysis, 99% sureBenchmarked the string-hashing paths and confirmed improvements with a release build in #53, before the cosmetic consolidation into #57.
  • Junwang Zhaosaw the final versionLLM analysis, 97% sureIdentified the copyright-year problem in #55, which was corrected before #57, and is explicitly credited as a reviewer by this commit.
  • John Naylorsaw the final versioncommittercommitted the patch
Add inline incremental hash functions for in-memory use
19 Jan 2024John Naylormaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #573 of 5 reviewers saw the final version

Takes the incremental-API and pgstat component of #57, leaving its C-string component for a separate commit. Differences are the stability-warning rewrite requested in #58, a license typo correction, and whitespace.

  • Jeff Davissaw an earlier versionLLM analysis, 98% sureFound a missing pointer increment and reported beneficial API testing in #33, then exercised the later API in #42, before further implementation changes.
  • Heikki Linnakangassaw the final versionLLM analysis, 100% sureReviewed the initial fasthash implementation in #24 and supplied the adopted final stability-warning wording and approval in #58.
  • jian hesaw the final versionLLM analysis, 99% sureReported header issues and benchmark results in #47 and verified the pgstat improvement with release-build measurements in #53.
  • Junwang Zhaosaw the final versionLLM analysis, 100% sureReported the incorrect copyright years in #55, which John agreed to correct in #56 and fixed in the final submission.
  • Andres Freundsaw an earlier versionLLM analysis, 96% sureCritiqued the proposed hash's mixing and requested exposed incremental state and inline processing in #21, directly prompting the fasthash redesign.

Credits across 12 commits

Author
John NaylorLLM6
Ants AasmaLLM2
Jeff DavisLLM1
Reviewer
John Naylorcommitter3
Reported by
Anton A. Melnikov2
Committer
John Naylor12

N LLM means N of the credits come from LLM analysis, not from commit trailers.