Apr 2024

1 commit
Fix ALTER DOMAIN NOT NULL syntax
15 Apr 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #371 of 1 reviewer saw the final version

Retains the grammar and syntax tests from #37, fixes a documentation typo, changes ruleutils.c to emit NOT NULL, and filters psql's Check column to check constraints with additional regression tests. The two behavioral amendments were proposed in #38 and acknowledged in #39.

  • jian hesaw the final versiontrailerReviewed the grammar and deparser in #32 and supplied the final deparser and psql filtering amendments in #38, which Peter confirmed incorporating in #39.

Mar 2024

2 commits
Catalog domain not-null constraints
20 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #182 of 2 reviewers saw the final version

Matches the catalog implementation patch in #18, with added function comments, const qualification for the check-expression argument, the conperiod comment correction, and a catalog-version bump. The requested comments and correction appear in #19 and #20.

  • Aleksander Alekseevsaw the final versiontrailerReported the domain-display failure in #2, then tested the final series on Raspberry Pi and Intel MacBook and requested function comments in #19.
  • jian hesaw the final versiontrailerReported duplicate NOT NULL constraints in #10, supplied the adopted idempotency fix in #14, and reviewed the final version's documentation and argument comment in #20.
Add tests for domain-related information schema views
20 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #181 of 1 reviewer saw the final version

Exactly matches the complete first patch in #18: 71 added lines in src/test/regress/sql/domain.sql and src/test/regress/expected/domain.out covering four domain-related information-schema views.

  • Aleksander Alekseevsaw the final versiontrailerReported successful testing of the final two-patch series on Raspberry Pi and Intel MacBook and said it looked good apart from implementation comments in #19.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Aleksander Alekseev2
jian he2
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.