pg_dump/nls.mk is missing a file
Hello.
Upon reviewing my translation, I discovered that filter.c was not
included in the nls.mk of pg_dump. Additional it appears that two '.h'
files have been included for a long time, but they seem unnecessary as
their removal does not affect the results. The attached patch is
intended to correct these issues.
For Meson, on the other hand, I believe there is nothing in particular
that needs to be done.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
pg_dump_nls_mk_fix.difftext/x-patch; charset=us-asciiDownload
diff --git a/src/bin/pg_dump/nls.mk b/src/bin/pg_dump/nls.mk
index cd91737f48..ca7ce74275 100644
--- a/src/bin/pg_dump/nls.mk
+++ b/src/bin/pg_dump/nls.mk
@@ -15,13 +15,12 @@ GETTEXT_FILES = $(FRONTEND_COMMON_GETTEXT_FILES) \
compress_zstd.c \
pg_dump.c \
common.c \
+ filter.c \
pg_dump_sort.c \
pg_restore.c \
pg_dumpall.c \
parallel.c \
- parallel.h \
pg_backup_utils.c \
- pg_backup_utils.h \
../../common/compression.c \
../../common/exec.c \
../../common/fe_memutils.c \
On 30 Nov 2023, at 04:00, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
Upon reviewing my translation, I discovered that filter.c was not
included in the nls.mk of pg_dump.
Fixed. I did leave the other headers in there since I don't feel comfortable
with changing that part in an otherwise unrelated thread (and maybe there are
more in the tree such that a bigger cleanup is possible?).
--
Daniel Gustafsson