model-writtenrun 3503 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed storing unset column statistics targets as NULL instead of -1, reducing tuple-descriptor size and adding SET STATISTICS DEFAULT while preserving legacy input syntax and ANALYZE's internal sentinel #1.
- Peter expanded the rebased submission with two WIP refactorings: a structure carrying nullable attribute fields alongside tuple descriptors, and copying index statistics targets during index creation instead of the later swap #2.
- Alvaro Herrera reviewed the main change, requested documentation for legacy -1 syntax and clearer nullable-field terminology, and questioned dropped-column handling #3; Peter incorporated that feedback and removed get_attstattarget() in favor of fetching directly inside examine_attribute() #4.
- Alvaro declared the first patch ready #6, and Peter landed it with minor integration and comment adjustments as 4f622503d6, leaving the two refactorings pending.
- Alvaro suggested resolving default targets before calling analyze functions and changing the extra-data structure's naming #5; Peter explained that extended statistics still needed to distinguish explicit targets from defaults, renamed the structure FormExtraData_pg_attribute, removed its pointer typedef, and added a matching nullable-stxstattarget patch to the remaining series #7.
- Review resumed in March when Tomas Vondra examined all three remaining patches, requested consistent ALTER STATISTICS parameter documentation and a description of tupdesc_extra, and questioned the default-target logic #8.
- Peter explained that accepting legacy -1 input constrained the implementation #9, and Tomas proposed clearer documentation and comments #10; Peter then introduced explicit default-target flags in both statistics and table commands and updated the documentation #11, which Tomas accepted #12.
- The nullable-stxstattarget constituent of #11 landed as 012460ee93, with only the catalog-version bump adjusted.
- The other two constituents of #11 landed separately: d939cb2fd6 generalized nullable attribute handling without substantive edits, and 6a004f1be8 moved statistics-target copying to index creation with whitespace cleanup; Peter confirmed the series was committed #13.
- At the thread's last message, Nathan Bossart reported compiler warnings about potentially uninitialized newtarget variables and supplied a two-line initialization fix, explaining that he saw no actual uninitialized-use risk #14; that attachment subsequently landed unchanged as 949300402b, completing all submitted work.