Jan 2025

2 commits
Support PG_UNICODE_FAST locale in the builtin collation provider.
17 Jan 2025Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Unicode full case mapping: PG_UNICODE_FAST, and standard-compliant UCS_BASIC (modified before commit)
Support Unicode full case mapping and conversion.
17 Jan 2025Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Unicode full case mapping: PG_UNICODE_FAST, and standard-compliant UCS_BASIC (modified before commit)

Mar - Apr 2024

14 commits
Fix test failures when language environment is not UTF-8.
4 Apr 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #851 of 1 reviewer saw the final version

Contains both initdb test additions attached retrospectively in #85, plus equivalent --lc-collate=C and --lc-ctype=C additions in src/bin/scripts/t/020_createdb.pl.

  • Thomas Munrosaw the final versionLLM analysis, 97% sureReported the committed C.UTF-8 initdb test's LATIN1 environment failure in #84, directly motivating the locale-setting repair.
Add unicode_strtitle() for Unicode Default Case Conversion.
30 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #680 of 1 reviewer saw the final version

Matches the unicode_strtitle component of #68, with local corrections in formatting.c to allocate the destination buffer correctly and reset wbstate.init before retrying conversion.

  • Peter Eisentrautsaw an earlier versiontrailerExamined titlecasing and its tests in #53 and #67, then accepted #68 subject to semantic questions before the final allocation and iterator-state corrections.
Use version for builtin collations.
29 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #681 of 1 reviewer saw the final version

Matches the versioning component of #68, apart from removing an assertion and adding the catalog-version bump. The separately attached cache refactoring is not included.

  • Peter Eisentrautsaw the final versiontrailerRequested version tracking in #57, recommended the string '1' in #67, and accepted the revised series in #76.
Fix convert_case(), introduced in 5c40364dd6.
24 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Direct response to Alexander Lakhin's Valgrind reproducer in #71, acknowledged as fixed in #72. It reorders the source-length check in convert_case, corrects destination bounds, and adds unit tests; no matching repair patch was attached.

  • Alexander Lakhinsaw the final versionLLM analysis, 100% sureProvided the minimal lower() query and Valgrind invalid-read report in #71 that directly prompted this repair.
Inline basic UTF-8 functions.
20 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #581 of 1 reviewer saw the final version

The UTF-8 inlining component of #58 matches the commit's changes in src/common/wchar.c and src/include/mb/pg_wchar.h, moving unicode_to_utf8 and utf8_to_unicode into inline definitions.

  • Peter Eisentrautsaw the final versiontrailerQuestioned the duplicate pg_utf_mblen implementation in #53 and explicitly accepted the revised inlining patch in #67.
Support C.UTF-8 locale in the new builtin collation provider.
19 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #580 of 3 reviewers saw the final version

Comes from the C.UTF-8 component of #58, with rewritten initcap workspace allocation and overflow checks in formatting.c, additional assertions, documentation adjustments, and rebasing over the locale-validation fixes.

  • Daniel Véritésaw an earlier versiontrailerTested builtin locale selection in #29 and Unicode property behavior in #38, before subsequent conversion and provider restructuring.
  • Peter Eisentrautsaw an earlier versiontrailerCompared C.UTF-8 behavior with libc in #57 and accepted #58 in #67, before the final workspace-allocation changes.
  • Jeremy Schneidersaw an earlier versiontrailerReviewed the initial infrastructure and tested initcap and psql behavior in #7 and #25, before the later implementation revisions.
Fix another warning, introduced by 846311051e.
18 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Responds directly to Tom Lane's MSVC missing-return warning in #62. It inverts builtin_locale_encoding's validity check so the function ends with an unconditional return, as explained in #63.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIdentified the missing-return warning and proposed making the return path explicit in #62.
Address more review comments on commit 2d819a08a1.
18 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #581 of 1 reviewer saw the final version

Matches the review-fix component of #58, with extra CREATE DATABASE wording, an initdb expected-output correction moved from the following component, and a catalog-version bump. Locale-validation context also reflects the intervening warning repair.

  • Peter Eisentrautsaw the final versionLLM analysis, 96% sureSupplied the documentation, encoding, initdb-output, and ICU-test corrections in #56, explicitly credited in both the attached repair and the commit.
Fix unreachable code warning from commit 2d819a08a1.
18 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Removes the unreachable encoding-check branch identified by Tom Lane's Coverity report in #60. Jeff Davis confirms the direct repair in #61; no corresponding standalone patch was attached.

  • Tom Lanesaw the final versionLLM analysis, 100% sureAnalyzed Coverity's warning and identified that required_encoding never changed from -1 in #60.
Introduce "builtin" collation provider.
14 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: Order changes in PG16 since ICU introduction (not this thread)
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #540 of 3 reviewers saw the final version

Matches the C-only provider component of #54, with initdb validation, locale-version argument fixes, reduced pg_dump refactoring, and command-line corrections confirmed in #55. This March 2024 source supersedes the June 2023 precursor #536142 claimed by thread #47790, so I disagree with that thread's attribution.

  • Daniel Véritésaw an earlier versiontrailerTested locale-provider configuration in #29 and supported the catalog rename in #34, before the provider was split and revised.
  • Peter Eisentrautsaw an earlier versiontrailerReviewed provider integration in #45 and #53, then reported his concurrent review of #54 in #56, while the committed version included additional validation changes.
  • Jeremy Schneidersaw an earlier versiontrailerExamined the infrastructure and reported provider-related psql and initcap behavior in #7 and #25, before substantial later revisions.
Catalog changes preparing for builtin collation provider.
9 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #521 of 1 reviewer saw the final version

Matches the catalog-renaming component of #52, with expanded catalogs.sgml explanations, pg_upgrade test-variable and version-parsing cleanup, and a catalog-version bump. It preserves the intended rename-only semantics.

  • Peter Eisentrautsaw the final versiontrailerRequested that the catalog patch contain only renaming in #45, which #48 implemented before subsequent light cleanup.
Unicode case mapping tables and functions.
7 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetsignificant changesfrom patchset #510 of 3 reviewers saw the final version

Extracts simple case mapping from the broader case-mapping component of #51, omitting SpecialCasing processing and string titlecasing and simplifying generated tables accordingly. Jeff Davis explicitly describes this split in #52.

  • Peter Eisentrautsaw an earlier versiontrailerReviewed the case-table implementation in #45 and specified full-mapping requirements in #47, before the implementation was expanded and then split for commit.
  • Daniel Veritesaw an earlier versiontrailerExamined case-mapping semantics in #4 and tested the provider in #29, before the shared conversion implementation and simple/full split.
  • Jeremy Schneidersaw an earlier versiontrailerReviewed the initial case-table plumbing in #7 and demonstrated initcap differences in #25, before substantial restructuring.
Add Unicode property tables.
6 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #510 of 3 reviewers saw the final version

Matches the property-table component of #51, adding src/common/unicode/README guidance and clearer generated ASCII-table comments. The property lookup implementation is retained.

  • Daniel Veritesaw an earlier versiontrailerTested the property tables against multiple ICU versions and explained failures in #38, before the later ASCII lookup optimization.
  • Peter Eisentrautsaw an earlier versiontrailerReviewed generator structure, property terminology, masks, and interfaces in #45, before the ASCII lookup optimization was added.
  • Jeremy Schneidersaw an earlier versiontrailerExamined the property-table plumbing in #7 and tested update-unicode reporting in #28, before later lookup and generator changes.
Documentation update for Standard Collations.
2 Mar 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #50

Derives from the standard-collations documentation component of #50, rewriting charset.sgml descriptions and stability wording while retaining its list-based organization.

Jan 2024

1 commit
Cleanup for unicode-update build target and test.
11 Jan 2024Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 1 reviewer saw the final version

Matches the cleanup component last attached in #23, with an additional PG_USED_FOR_ASSERTS_ONLY declaration fix in category_test.c. It does not contain the checked-codepoint counter proposed in #28.

  • Jeremy Schneidersaw the final versiontrailerCalled the cleanup straightforward and recommended committing it in #24, before only a small assertion-build declaration fix was added.

Dec 2023

1 commit
Shrink Unicode category table.
7 Dec 2023Jeff Davismaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #1

Matches the category-table compaction component of #1: unassigned ranges are omitted from the generated table and lookup returns PG_U_UNASSIGNED for missing entries.

Credits across 18 commits

Author
Jeff DavisLLM15
Reviewer
Peter Eisentraut10
Jeremy Schneider5
Daniel Verite4
Daniel Vérité2
Reported by
Tom Lane2
Alexander Lakhin1
Thomas Munro1
Committer
Jeff Davis18

N LLM means N of the credits come from LLM analysis, not from commit trailers.