Some useless includes in llvmjit_inline.cpp

Started by Thomas Munroabout 2 years ago2 messages
#1Thomas Munro
thomas.munro@gmail.com
1 attachment(s)

Hi,

This is not exhaustive, I just noticed in passing that we don't need these.

Attachments:

0001-Remove-useless-includes-from-llvmjit_inline.cpp.patchtext/x-patch; charset=US-ASCII; name=0001-Remove-useless-includes-from-llvmjit_inline.cpp.patchDownload
From ccadf2778192db48376632c35474736a3370b0c2 Mon Sep 17 00:00:00 2001
From: Thomas Munro <thomas.munro@gmail.com>
Date: Mon, 11 Dec 2023 13:50:18 +1300
Subject: [PATCH] Remove useless includes from llvmjit_inline.cpp.

---
 src/backend/jit/llvm/llvmjit_inline.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/jit/llvm/llvmjit_inline.cpp b/src/backend/jit/llvm/llvmjit_inline.cpp
index d92d7f3c88..d6e6f2a559 100644
--- a/src/backend/jit/llvm/llvmjit_inline.cpp
+++ b/src/backend/jit/llvm/llvmjit_inline.cpp
@@ -34,9 +34,7 @@ extern "C"
 #include <sys/types.h>
 #include <unistd.h>
 
-#include "common/string.h"
 #include "miscadmin.h"
-#include "storage/fd.h"
 }
 
 #include <llvm-c/Core.h>
-- 
2.39.2

#2Shubham Khanna
khannashubham1197@gmail.com
In reply to: Thomas Munro (#1)
Re: Some useless includes in llvmjit_inline.cpp

On Mon, Dec 11, 2023 at 6:28 AM Thomas Munro <thomas.munro@gmail.com> wrote:

Hi,

This is not exhaustive, I just noticed in passing that we don't need these.

I was able to compile the changes with "--with-llvm" successfully, and
the changes look good to me.

Thanks and Regards,
Shubham Khanna.