Update the comment in nodes.h to cover Cardinality

Started by Richard Guoover 2 years ago3 messageshackers
Jump to latest
#1Richard Guo
guofenglinux@gmail.com

By chance I discovered that the comment for the typedefs of "double"s
does not cover Cardinality. Should we update that comment accordingly,
maybe something like below?

- * Typedefs for identifying qualifier selectivities and plan costs as such.
- * These are just plain "double"s, but declaring a variable as Selectivity
- * or Cost makes the intent more obvious.
+ * Typedefs for identifying qualifier selectivities, plan costs and
+ * estimated rows or other count as such.  These are just plain "double"s,
+ * but declaring a variable as Selectivity, Cost or Cardinality makes the
+ * intent more obvious.

Thanks
Richard

Attachments:

v1-0001-Add-comment-for-Cardinality-typedef.patchapplication/octet-stream; name=v1-0001-Add-comment-for-Cardinality-typedef.patchDownload+4-4
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Richard Guo (#1)
Re: Update the comment in nodes.h to cover Cardinality

On 19.12.23 07:23, Richard Guo wrote:

By chance I discovered that the comment for the typedefs of "double"s
does not cover Cardinality.  Should we update that comment accordingly,
maybe something like below?

- * Typedefs for identifying qualifier selectivities and plan costs as such.
- * These are just plain "double"s, but declaring a variable as Selectivity
- * or Cost makes the intent more obvious.
+ * Typedefs for identifying qualifier selectivities, plan costs and
+ * estimated rows or other count as such.  These are just plain "double"s,
+ * but declaring a variable as Selectivity, Cost or Cardinality makes the
+ * intent more obvious.

Fixed, thanks.

#3Richard Guo
guofenglinux@gmail.com
In reply to: Peter Eisentraut (#2)
Re: Update the comment in nodes.h to cover Cardinality

On Tue, Dec 19, 2023 at 10:50 PM Peter Eisentraut <peter@eisentraut.org>
wrote:

On 19.12.23 07:23, Richard Guo wrote:

By chance I discovered that the comment for the typedefs of "double"s
does not cover Cardinality. Should we update that comment accordingly,
maybe something like below?

- * Typedefs for identifying qualifier selectivities and plan costs as

such.

- * These are just plain "double"s, but declaring a variable as

Selectivity

- * or Cost makes the intent more obvious.
+ * Typedefs for identifying qualifier selectivities, plan costs and
+ * estimated rows or other count as such.  These are just plain

"double"s,

+ * but declaring a variable as Selectivity, Cost or Cardinality makes

the

+ * intent more obvious.

Fixed, thanks.

Thanks for the fix!

Thanks
Richard