Dec 2023

5 commits
Revert "pg_stat_statements: Add coverage for entry_dealloc()"
31 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1reverts 1 commit here
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

This removes the max regression test and its configuration and build integration, reverting 742f6b3e6d. No revert patch was attached; the buildfarm failure report in #9 and Peter's proposed revert in #11 explain the change.

  • Michael Paquiersaw an earlier versionLLM analysis, 90% sureMichael reported the committed eviction test's missing t001 result before the revert in #9, reviewing the work from #5 rather than the later diagnostic attachment in #13.
pg_stat_statements: Add coverage for entry_dealloc()
30 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #51 of 2 reviewers saw the final version

The commit uses the eviction patch from #5, with light edits to sql/max.sql and expected/max.out: explanatory comments, simplified count checks, an extra generated query, and a dealloc > 0 assertion. Peter confirms these review-driven edits and the commit in #7.

  • Michael Paquiersaw an earlier versiontrailerMichael proposed PL/pgSQL loops in #2, after which #5 changed statement execution from gexec to nested tracked statements, materially altering which entries the test creates.
  • Julien Rouhaudsaw the final versiontrailerJulien verified track=all in #4 and reviewed the revised test in #6, requesting clearer count assertions and a deallocation-counter check that Peter incorporated.
pg_stat_statements: Add TAP test for testing restarts
30 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #52 of 2 reviewers saw the final version

The complete restart-test patch in #5 matches the committed changes to Makefile, meson.build, and t/010_restart.pl. It checks actual query contents across restart and their absence with pg_stat_statements.save=false.

  • Michael Paquiersaw the final versiontrailerMichael requested comparison of saved contents instead of only counts in #2, and #5 implements that light test refinement.
  • Julien Rouhaudsaw the final versiontrailerJulien said the revised restart test looked good in #6, and that attached version landed unchanged.
pg_stat_statements: Add test coverage for pg_stat_statements_1_8()
27 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The pg_stat_statements_1_8() patch in #1 matches the committed changes to sql/oldextversions.sql and expected/oldextversions.out, adding a view read while version 1.8 is installed. Peter confirms its earlier landing in #5.

  • Michael Paquiersaw the final versiontrailerMichael accepted the old-version coverage additions in #2, and the version-1.8 patch landed unchanged.
pg_stat_statements: Add test coverage for pg_stat_statements_reset_1_7
27 Dec 2023Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

The reset-function patch in #1 matches the committed additions to sql/oldextversions.sql and expected/oldextversions.out, including both reset calls. Peter confirms that this component had already landed in #5.

  • Michael Paquiersaw the final versiontrailerMichael accepted the old-version coverage additions in #2, and the reset patch landed without substantive changes.

Credits across 5 commits

Author
Peter EisentrautLLM4
Reviewer
Michael Paquier4
Julien Rouhaud2
Committer
Peter Eisentraut5

N LLM means N of the credits come from LLM analysis, not from commit trailers.