model-writtenrun 3729 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut opened the thread with five independent patches for pg_stat_statements coverage: legacy entry points, entry eviction, restart persistence, and LCOV exclusions for unreachable legacy functions; gc_qtexts() remained future work #1.
- Michael Paquier questioned the LCOV exclusions, proposed PL/pgSQL loops to reduce eviction-test output, and requested checking saved query contents across restarts #2; Peter explained that 100 was the hardcoded minimum entry limit #3, and Julien Rouhaud demonstrated that nested statements are tracked with track=all #4.
- The two old-extension tests from #1 landed unchanged as 3727b8d0e3 and 3e527aeeed; Peter then posted the remaining three patches with PL/pgSQL eviction loops and stronger restart assertions #5.
- Julien approved the revised tests while asking for clearer eviction assertions and a positive deallocation-counter check, and joined Michael's objections to the LCOV exclusions #6.
- Peter incorporated the eviction-test refinements in 742f6b3e6d and committed the restart patch unchanged from #5 as 4710b67d4d, announcing both landings and dropping the LCOV patch in #7.
- Michael reported that the new eviction test failed because the t001 entry disappeared prematurely #9; Julien suspected concurrent tests #10, but Peter explained that execution was isolated and serial and identified failures on big-endian systems #11.
- Following Peter's proposal to revert pending diagnosis #11, 1141e29b61 removed the eviction test and its supporting configuration while retaining the restart and old-extension tests.
- Tom Lane offered to investigate on his failing buildfarm machine #12 and supplied diagnostic logging showing that tracked PL/pgSQL subexpressions filled the entry table earlier than expected; platform-dependent hash traversal then changed which equally used entries were evicted #13.
- At the thread's end, the eviction test remained reverted: Tom recommended rewriting it with more headroom and verifying eviction timing with instrumentation, but supplied no replacement test, while the other three test additions remained committed #13.