Should "CRC" be in uppercase?
Started by Kyotaro Horiguchiabout 2 years ago2 messages
A new function check_control_file() in pg_combinebackup.c has the
following message.
pg_fatal("%s: crc is incorrect", controlpath);
I think "crc" should be in all uppercase in general and a brief
grep'ing told me that it is almost always or consistently used in
uppercase in our tree.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
upper_case_crc.difftext/x-patch; charset=us-asciiDownload
diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c
index b6ae6f2aef..049c60cbf8 100644
--- a/src/bin/pg_combinebackup/pg_combinebackup.c
+++ b/src/bin/pg_combinebackup/pg_combinebackup.c
@@ -538,7 +538,7 @@ check_control_files(int n_backups, char **backup_dirs)
/* Control file contents not meaningful if CRC is bad. */
if (!crc_ok)
- pg_fatal("%s: crc is incorrect", controlpath);
+ pg_fatal("%s: CRC is incorrect", controlpath);
/* Can't interpret control file if not current version. */
if (control_file->pg_control_version != PG_CONTROL_VERSION)
Re: Should "CRC" be in uppercase?
On Mon, Dec 25, 2023 at 12:51 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
A new function check_control_file() in pg_combinebackup.c has the
following message.pg_fatal("%s: crc is incorrect", controlpath);
I think "crc" should be in all uppercase in general and a brief
grep'ing told me that it is almost always or consistently used in
uppercase in our tree.
I pushed this also.