No LINGUAS file yet for pg_combinebackup

Started by Tom Laneabout 2 years ago3 messages
#1Tom Lane
tgl@sss.pgh.pa.us

Since dc2123400, any "make" in src/bin/pg_combinebackup whines

cat: ./po/LINGUAS: No such file or directory

if you have selected --enable-nls. This is evidently from

AVAIL_LANGUAGES := $(shell cat $(srcdir)/po/LINGUAS)

I don't particularly care to see that warning until whenever
it is that the translations first get populated. Perhaps
we should hack up nls-global.mk to hide the warning, but
that might bite somebody someday. I'm inclined to just
add an empty LINGUAS file as a temporary measure.
Thoughts?

regards, tom lane

#2Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#1)
Re: No LINGUAS file yet for pg_combinebackup

On Mon, Dec 25, 2023 at 12:48:17PM -0500, Tom Lane wrote:

I don't particularly care to see that warning until whenever
it is that the translations first get populated. Perhaps
we should hack up nls-global.mk to hide the warning, but
that might bite somebody someday. I'm inclined to just
add an empty LINGUAS file as a temporary measure.
Thoughts?

I've noticed this noise as well, so +1 for the temporary empty file.
--
Michael

#3Peter Eisentraut
peter.eisentraut@enterprisedb.com
In reply to: Michael Paquier (#2)
Re: No LINGUAS file yet for pg_combinebackup

On 26.12.23 13:18, Michael Paquier wrote:

On Mon, Dec 25, 2023 at 12:48:17PM -0500, Tom Lane wrote:

I don't particularly care to see that warning until whenever
it is that the translations first get populated. Perhaps
we should hack up nls-global.mk to hide the warning, but
that might bite somebody someday. I'm inclined to just
add an empty LINGUAS file as a temporary measure.
Thoughts?

I've noticed this noise as well, so +1 for the temporary empty file.

I checked that meson also complains about the missing file, except that
we hadn't equipped pg_combinebackup with NLS support in meson yet. So I
added that as well. So having the empty file is the correct solution
for both build systems. Tom has already added the empty file.