Update docs for default value of fdw_tuple_cost

Started by Umair Shahidabout 2 years ago5 messages
#1Umair Shahid
umair.shahid@stormatics.tech
1 attachment(s)

Hi

Commit cac169d686eddb277880a0d8a760ac3007b4846a updated the default value
of fdw_tuple_cost from 0.01 to 0.2. The attached patch updates the docs to
reflect this change.

Thanks!

Umair Shahid | Founder

Professional Services for PostgreSQL
https://stormatics.tech/

Attachments:

update-doc-default-fdw_tuple_value.patchapplication/octet-stream; name=update-doc-default-fdw_tuple_value.patchDownload
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index 2ba96aa295..3c54a26c9a 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -303,7 +303,7 @@ OPTIONS (ADD password_required 'false');
        scans on that server.  This represents the additional overhead of
        data transfer between servers.  You might increase or decrease this
        number to reflect higher or lower network delay to the remote server.
-       The default value is <literal>0.01</literal>.
+       The default value is <literal>0.2</literal>.
       </para>
      </listitem>
     </varlistentry>
#2Richard Guo
guofenglinux@gmail.com
In reply to: Umair Shahid (#1)
Re: Update docs for default value of fdw_tuple_cost

On Wed, Dec 27, 2023 at 12:27 AM Umair Shahid <umair.shahid@stormatics.tech>
wrote:

Commit cac169d686eddb277880a0d8a760ac3007b4846a updated the default value
of fdw_tuple_cost from 0.01 to 0.2. The attached patch updates the docs to
reflect this change.

+1. Nice catch.

Thanks
Richard

Show quoted text
#3Chris Travers
chris.travers@gmail.com
In reply to: Richard Guo (#2)
Re: Update docs for default value of fdw_tuple_cost

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed

Good catch. This is a trivial fix and so I hope we can just get it in right away.

The new status of this patch is: Ready for Committer

#4John Naylor
johncnaylorls@gmail.com
In reply to: Umair Shahid (#1)
Re: Update docs for default value of fdw_tuple_cost

On Tue, Dec 26, 2023 at 11:27 PM Umair Shahid
<umair.shahid@stormatics.tech> wrote:

Commit cac169d686eddb277880a0d8a760ac3007b4846a updated the default value of fdw_tuple_cost from 0.01 to 0.2. The attached patch updates the docs to reflect this change.

Pushed, thanks!

#5Umair Shahid
umair.shahid@stormatics.tech
In reply to: John Naylor (#4)
Re: Update docs for default value of fdw_tuple_cost

On Thu, Jan 11, 2024 at 7:07 AM John Naylor <johncnaylorls@gmail.com> wrote:

On Tue, Dec 26, 2023 at 11:27 PM Umair Shahid
<umair.shahid@stormatics.tech> wrote:

Commit cac169d686eddb277880a0d8a760ac3007b4846a updated the default

value of fdw_tuple_cost from 0.01 to 0.2. The attached patch updates the
docs to reflect this change.

Pushed, thanks!

Thank you, John.

And thank you Chris Travers for the review.