Jan 2024

3 commits
Support shared libraries on Android (using make)
23 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #74 of 4 reviewers saw the final version

The commit preserves the Android behavior from #7, but uses shlib_bare for both shlib and soname and retains a single shared linker assignment in src/Makefile.shlib. It omits the documentation addition; Peter explicitly describes this as a reworking of Matthias's patch in #18.

  • Michael Paquiersaw the final versionLLM analysis, 97% sureMichael identified the missing documentation and Meson coverage in #3, prompting the documentation revision in #5; subsequent Makefile changes were light.
  • Robert Haassaw the final versionLLM analysis, 99% sureRobert identified misleading wording and a typo in #6, then reviewed the corrected comment and requested stronger evidence for Android's restriction in #8.
  • Andres Freundsaw the final versionLLM analysis, 85% sureAndres investigated the disputed library-naming requirement and supplied Android documentation supporting unversioned names in #12.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
meson: Map host_system android to linux
23 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #112 of 2 reviewers saw the final version

The meson.build Android-to-Linux mapping matches #11, with only comment wrapping and rebased context after the portname ordering fix. The commit explicitly credits Andres Freund, who sent that patchset.

  • Matthias Kuhnsaw the final versionLLM analysis, 100% sureMatthias tested Andres's patch, reported the missing port/android.h failure in #15, and confirmed successful unversioned Android output after the ordering fix in #17.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
meson: portname was set too early
23 Jan 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.2
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit moves portname assignment below host_system normalization in meson.build, exactly the fix Peter proposed without an attachment in #16. Git confirms this is the development-branch commit and 8b31b689f4 is its REL_16_STABLE counterpart, so the duplicate candidate is consolidated here under the one-verdict-per-change rule.

  • Matthias Kuhnsaw the final versionLLM analysis, 100% sureMatthias tested Peter's inline ordering fix and reported that the build progressed and produced the expected platform-dependent library names in #17.

Credits across 3 commits

Author
Andres Freund1
Matthias KuhnLLM1
Peter EisentrautLLM1
Reviewer
Peter Eisentrautcommitter2
Reported by
Matthias Kuhn1
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.