Feb 2025

5 commits
Reduce scope of heap vacuum per_buffer_data
18 Feb 2025Melanie Plagemanmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Moves per_buffer_data initialization inside lazy_scan_heap()'s loop exactly as Tom Lane proposed in #66; no attachment contains this change, and Melanie reports pushing it in #67.

  • Tom Lanesaw the final versionLLM analysis, 100% sureProposed the precise scope and initialization change adopted by the commit in #66, before it was committed.
Fix explicit valgrind interaction in read_stream.c.
15 Feb 2025Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.5
LLM analysis, 100% suremodified before commitlight changesfrom patchset #612 of 2 reviewers saw the final version

Matches the three read_stream.c hunks in #61, with the malformed nested wipe_mem/get_per_buffer_data invocation corrected to wipe_mem(per_buffer_data, stream->per_buffer_data_size). Melanie confirmed the corrected version worked in #64.

  • Melanie Plagemansaw the final versiontrailerReproduced the Valgrind failure and confirmed the corrected patch fixed it in #64.
  • Tom Lanesaw the final versiontrailerReviewed the implementation and backpatch timing in #62, after which only a malformed function call was corrected.
Use streaming read I/O in VACUUM's third phase
14 Feb 2025Melanie Plagemanmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #571 of 1 reviewer saw the final version

The complete third-phase patch in #57 has the same stable patch ID as the commit, including vacuum_reap_lp_read_stream_next() and TidStore result copying; Thomas Munro is credited as co-author.

  • Masahiko Sawadasaw the final versiontrailerReviewed the third-phase consumer in #51, requested loop-local iter_result, and accepted the revised series in #56.
Use streaming read I/O in VACUUM's first phase
14 Feb 2025Melanie Plagemanmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #571 of 2 reviewers saw the final version

The complete first-phase streaming patch in #57 has the same stable patch ID as the commit, including the failsafe guard and adjusted FSM range.

  • Masahiko Sawadasaw the final versiontrailerIdentified allocation-size and FSM-boundary issues in #51, then supplied the final failsafe condition and comment correction in #56.
  • Thomas Munrosaw an earlier versiontrailerInvestigated streaming performance in #35 and reported testing and approval in #53, before the subsequent FSM-boundary and failsafe logic changes.
Convert heap_vac_scan_next_block() boolean parameters to flags
14 Feb 2025Melanie Plagemanmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #572 of 2 reviewers saw the final version

The flags-conversion patch in #57 has the same stable patch ID as the commit; its code was already unchanged from #52.

  • Masahiko Sawadasaw the final versiontrailerReviewed the flags conversion and variable scope in #51, with only naming and presentation changes to this component afterward.
  • Thomas Munrosaw the final versiontrailerReported reading and testing the series in #53, and the flags-conversion component subsequently remained unchanged.

Jul 2024

1 commit
Refactor tidstore.c iterator buffering.
24 Jul 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #361 of 1 reviewer saw the final version

Matches Thomas Munro's TidStore prerequisite forwarded in #36, except for removal of unrelated return-expression and loop-variable cosmetic changes. Noah requested those omissions in #40, and Thomas confirmed them in #41.

  • Noah Mischsaw the final versiontrailerValidated the iterator lifetime and concurrency assumptions and approved the patch subject to removing two cosmetic changes in #40.

Apr 2024

1 commit
Increase default vacuum_buffer_usage_limit to 2MB.
6 Apr 2024Thomas Munromaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: Streaming read-ready sequential scan code (part of a posted patchset)

Mar 2024

3 commits
Remove unneeded vacuum_delay_point from heap_vac_scan_get_next_block
11 Mar 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #301 of 1 reviewer saw the final version

The delay-point removal in #30 has the same stable patch ID as the commit: one vacuum_delay_point() deletion in find_next_unskippable_block(). Both the forwarded patch and commit credit Melanie Plageman.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Confine vacuum skip logic to lazy_scan_skip()
11 Mar 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: Streaming I/O, vectored I/O (WIP) (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #300 of 1 reviewer saw the final version

Matches the refactor in #30, with comment revisions and equivalent OR-condition reordering requested in #31 and confirmed in #32. The commit credits Melanie Plageman and Heikki Linnakangas as authors.

  • Andres Freundsaw an earlier versiontrailerProposed embedding state, retaining loop-local variables, and simplifying the iterator interface in #3, before substantial subsequent restructuring.
Set all_visible_according_to_vm correctly with DISABLE_PAGE_SKIPPING
11 Mar 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.3
LLM analysis, 100% surelanded as postedfrom patchset #232 of 2 reviewers saw the final version

The visibility-map fix in #23 has the same stable patch ID as the commit, removing the forced false visibility result under DISABLE_PAGE_SKIPPING. Its commit and backpatch are announced in #30.

  • Melanie Plagemansaw the final versiontrailerAnalyzed incorrect VM-bit clearing in #24, explicitly checked the attached fix in #25, and supported it in #26.
  • Peter Geoghegansaw the final versiontrailerReviewed the exact underlying visibility-map behavior and correction in #18, #21, and #22 before the fix was attached.

Credits across 10 commits

Author
Melanie Plageman2 LLM5
Thomas MunroLLM3
Heikki Linnakangas1 LLM2
Reviewer
Masahiko Sawada3
Andres Freund2
Melanie Plageman2
Thomas Munro2
Heikki Linnakangascommitter1
Noah Misch1
Peter Geoghegan1
Tom Lane1
Tested by
Melanie Plageman1
Co author
Thomas Munro1
Committer
Melanie Plageman4
Heikki Linnakangas3
Thomas Munro3

N LLM means N of the credits come from LLM analysis, not from commit trailers.