Jun 2024

1 commit
meson: Restore implicit warning/debug/optimize flags for extensions
7 Jun 2024Peter Eisentrautmaster17beta2REL_19_STABLE17beta2REL_18_STABLE17beta2REL_17_STABLE17beta2
LLM analysis, 100% suremodified before commitlight changesfrom patchset #151 of 4 reviewers saw the final version

The commit preserves all executable additions from #15, including identical src/include/meson.build exports. It relocates the meson.build flag-computation block, rewrites its comments and revises the commit message.

  • Tristan Partinsaw an earlier versionLLM analysis, 94% sureTristan confirmed the reported problem and extended the initial fix in #3, then explained the missing exported -Wall in #6; the committed implementation subsequently replaced that approach.
  • Michael Paquiersaw an earlier versionLLM analysis, 88% sureMichael reported unsuccessful reproduction with GCC 13.2 and questioned the consequences of adding -Wformat in #4, before the implementation was substantially reworked.
  • Andres Freundsaw an earlier versionLLM analysis, 98% sureAndres challenged unnecessary MSVC flag probes and excessive warning levels in #12, prompting their removal before further warning-selection logic changes.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Sutou Kouhei1
Reviewer
Peter Eisentrautcommitter1
Committer
Peter Eisentraut1