model-writtenrun 3606 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed separating row-type equality from full tuple-descriptor equality, introducing equalRowTypes() for most callers and renaming the corresponding hash function to clarify which fields matter #1.
- Tom Lane requested collation comparison, while jian he questioned whether the hash should include every compared field; Peter explained that hashing fewer fields remains valid and involves a performance tradeoff #2 #3 #4.
- Peter revised the patch to compare collation and dropped-column status, documented the distinction between row-type fields, physical layout, and table metadata, and left an explicit question about checking array dimensions #5.
- Tom supported the added checks but argued against treating attndims as a core semantic field because its removal was under discussion; jian he subsequently requested clarification of the hash behavior #6 #7.
- Tomas Vondra verified that every switched caller needed only the weaker checks, confirmed that the remaining callers needed full descriptor equality, supported excluding attndims, and explained that hash collisions already require equality checks #8 #9.
- Peter committed the revised patch with only comment and commit-description edits as 20e58105ba, leaving attndims unchecked and the hash inputs unchanged; his final message confirmed completion with no outstanding patch series #10.