model-writtenrun 3501 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed simplifying Perl file-operation error handling with autodie and attached a demonstration for Catalog.pm and genbki.pl in #1; Greg Sabino Mullane endorsed it in #2, and John Naylor confirmed that the current minimum Perl version supported it in #3.
- Tom Lane warned that removing explicit checks could make future backpatches unsafe on branches without autodie in #4; Peter suggested limiting adoption to new scripts in #5, but Tom instead proposed waiting until all supported branches could use it or raising older branches' Perl requirement in #7.
- Daniel Gustafsson, Greg Sabino Mullane, and Andrew Dunstan supported raising the older branches' Perl requirement in #8, #9, and #11; Dagfinn Ilmari Mannsåker supplied platform-support context in #10, and Tom reported successful pre-v16 buildfarm runs with Perl 5.10.1 in #12.
- Peter proposed a gentler prerequisite in #13: use perlcritic to require explicit error checks, which could also detect unsafe backpatches after future autodie adoption; Andrew and Daniel supported this direction in #14 and #15.
- Peter supplied the replacement implementation in #16, enabling RequireCheckedSyscalls for eight functions and fixing unchecked calls throughout test and build scripts; a second patch expressed the same selection as an exclusion list, while broader checking remained open for future work.
- Peter chose the exclusion list and consolidated the patches with explanatory comments and a complete commit message in #17; Andrew confirmed that two buildfarm animals already ran perlcritic in #18.
- Daniel approved the consolidated patch in #19 while noting inconsistent error-handler operators; after Dagfinn explained the precedence hazard of '|| die' in #20, Daniel checked the affected expressions and found none vulnerable in #21.
- Peter committed #17 as d56cb42b54, changing only two error-handler operators in src/tools/msvc_gendef.pl beyond rebase adjustments, and announced completion in #22; the perlcritic work landed, while autodie adoption and checking additional functions remained future possibilities.