Combine headerscheck and cpluspluscheck scripts
headerscheck started in 55ea1091884 (2019) essentially as an adjusted
copy of cpluspluscheck. Since then two scripts have not drifted far
apart. But there are occasionally mistakes keeping the two exclude
lists updated together. I figure we can just combine the two scripts
into one, so it's easier to keep updated.
The attached patch adds an option --cplusplus to headerscheck, with
which it does the same thing as cpluspluscheck, and cpluspluscheck is
removed. The top-level make targets stay the same.
Attachments:
0001-Combine-headerscheck-and-cpluspluscheck-scripts.patchtext/plain; charset=UTF-8; name=0001-Combine-headerscheck-and-cpluspluscheck-scripts.patchDownload+54-234
On Thu, Mar 07, 2024 at 01:37:36PM +1300, Thomas Munro wrote:
+1
Looking at the patch, nice cleanup.
--
Michael
On 07.03.24 08:30, Michael Paquier wrote:
On Thu, Mar 07, 2024 at 01:37:36PM +1300, Thomas Munro wrote:
+1
Looking at the patch, nice cleanup.
Committed, thanks.
Hello, hackers,
On 10/03/2024 12:03, Peter Eisentraut wrote:
Committed, thanks.
This commit (7b8e2ae2f) have turned cpluspluscheck script into a
--cplusplus option for headerscheck. I propose to update the
src/tools/pginclude/README correspondingly, please see the attached patch.
--
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru
Attachments:
0001-Update-src-tools-pginclude-README-to-match-recent-ch.patchtext/x-patch; charset=UTF-8; name=0001-Update-src-tools-pginclude-README-to-match-recent-ch.patchDownload+12-13
On 16.04.24 17:17, Anton Voloshin wrote:
On 10/03/2024 12:03, Peter Eisentraut wrote:
Committed, thanks.
This commit (7b8e2ae2f) have turned cpluspluscheck script into a
--cplusplus option for headerscheck. I propose to update the
src/tools/pginclude/README correspondingly, please see the attached patch.
Fixed, thanks!