model-writtenrun 3573 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed an IWYU-assisted cleanup of backend C includes, testing several conditional build configurations while excluding broad include additions and catalog-header substitutions to limit scope #1.
- Nathan Bossart pointed to earlier cleanup work and supported easier include maintenance, Peter distinguished compiler-based symbol tracking from trial removal, and Tristan Partin suggested build targets and eventual CI integration #2 #3 #4 #5.
- Andres Freund identified incorrect removal of global-declaration headers, questionable main.c substitutions, and an event_trigger.c build failure, while requesting policies and annotations to avoid exposing implementation details through direct includes #6.
- Alvaro Herrera found the BRIN changes and executor-header substitutions acceptable, while Tom Lane warned about headers needed only in untested conditional code; Andres supported targeted substitutions but wanted more annotation infrastructure for broader automated cleanup #7 #8 #9.
- Peter's next revision corrected the reported include problems and rebased the patch; he traced the global-variable issue to an IWYU deficiency, reported it upstream, and left the catalog-header policy unresolved #10.
- In the final thread message, Peter additionally retained portability headers to protect configurations outside CI coverage and proposed committing the cleanup, leaving further IWYU integration for future work #11.
- Peter subsequently committed that final 425-file cleanup as dbbca2cf29, matching #11 modulo rebase and whitespace, with the commit message documenting the retained global-declaration and portability headers.