model-writtenrun 3596 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Bharath Rupireddy proposed correcting an error hint that named adminpack's pg_logfile_rotate() instead of core's pg_rotate_logfile(), and Daniel Gustafsson supported backpatching the correction through PostgreSQL 12 #1 #2.
- Nathan Bossart highlighted the confusing mapping between SQL and C function names; Daniel considered renaming unnecessary churn but proposed dropping obsolete adminpack support in PostgreSQL 17 while fixing the hint on stable branches #3 #4.
- Bharath found only archived pgAdmin III usage and sought input from its developers; Dave Page explained the historical compatibility naming and confirmed that pgAdmin 4's replacement functionality would not use adminpack, supporting removal of the extension #5 #6.
- Daniel submitted a new patch removing adminpack, its build and documentation entries, and obsolete core compatibility functions, deliberately leaving the catalog-version bump until commit #7.
- Tom Lane checked for missed references and approved the removal, Nathan agreed, and Bharath subsequently reported that it looked good; Daniel allowed additional comment time through the next CommitFest #8 #9 #10 #11.
- Daniel committed the removal patch with the deferred catalog-version bump as cc09e6549f and confirmed completion in the final message #12; removal eliminated the faulty hint on the development branch, while the thread records no outcome for the proposed stable-branch typo correction.