Mar 2024

2 commits
doc: Document error handling in PGTYPESnumeric_to_long
25 Mar 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

This commit updates the PGTYPESnumeric_to_long documentation in doc/src/sgml/ecpg.sgml to describe underflow and PGTYPES_NUM_UNDERFLOW, addressing Aidar's report #11. No attached patch contains this hunk; Daniel confirms fixing it in #12.

  • Aidar Imamovsaw the final versionLLM analysis, 94% sureAidar identified the missing documentation for PGTYPESnumeric_to_long underflow handling #11, which Daniel subsequently fixed #12.
ecpg: Fix return code for overflow in numeric conversion
25 Mar 2024Daniel Gustafssonmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #101 of 2 reviewers saw the final version

The commit diff exactly matches #10 after normalizing index metadata, including both errno-based overflow checks in src/interfaces/ecpg/compatlib/informix.c and all six expected-result changes. Although Daniel sent the final patch, its header and the commit credit Aidar Imamov, who submitted the original implementation #1.

  • Michael Paquiersaw an earlier versionLLM analysis, 88% sureMichael accepted the error-code changes for HEAD but raised compatibility concerns about backpatching #4, before Daniel removed the underflow behavior in #10.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Aidar Imamov1
Reviewer
Daniel Gustafssoncommitter1
Reported by
Aidar Imamov1
Committer
Daniel Gustafsson2