model-writtenrun 3540 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Aidar Imamov reported that dectoint() and dectolong() could never return their documented overflow code because they compared a 0-or-minus-1 return value with an errno constant; his initial patch corrected that check and also added underflow behavior, documentation, and expected test results #1.
- Daniel Gustafsson found the patch generally sound but requested removal of unnecessary variable initialization and separate handling of unrelated documentation wording fixes #2; Aidar incorporated those changes and sent the wording fixes to the documentation list #3.
- Michael Paquier supported the change for HEAD but warned that changing error codes could affect existing applications #4, and Daniel initially agreed against backpatching #5.
- After checking Informix compatibility requirements, Daniel removed the proposed underflow behavior because the emulated functions do not provide an underflow return value, posting an overflow-only patch that he considered potentially suitable for backpatching #10.
- Aidar agreed with the narrower fix and separately pointed out that PGTYPESnumeric_to_long already sets an underflow errno that its documentation omitted #11.
- Daniel committed the overflow-only patch #10 unchanged as b2d6b4c728 and addressed Aidar's documentation report #11 separately in 68174679fe.
- Daniel's final message confirmed both fixes had landed but left backpatching open for further opinions, citing the absence of user reports and uncertainty about ECPG testing across minor upgrades #12.