Apr 2025

7 commits
Add missing declarations to pg_config.h.in
3 Apr 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #391 of 1 reviewer saw the final version

Exactly matches both pg_config.h.in hunks attached in #39, adding HAVE_DECL_TIMINGSAFE_BCMP and HAVE_TIMINGSAFE_BCMP.

  • Heikki Linnakangassaw the final versiontrailerExplicitly approved the attached fix in #40.
docs: Add a new section and a table listing protocol versions
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #37

Matches the protocol-versions section and table from #37, with revised introductory wording and adjustments for documentation already changed by preceding commits.

Make cancel request keys longer
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #370 of 2 reviewers saw the final version

Derives from the longer-key attachment in #37, correcting the PostgresMain protocol threshold from 3.1 to 3.2, expanding middleware key-length documentation, and removing an obsolete typedef entry. A negotiation-error cleanup was moved into the preceding negotiation commit.

  • Jelte Fennema-Niosaw an earlier versiontrailerReviewed packet formats and signaling in #2, #5, and #9, then supplied the merged revision in #33, before the final protocol-threshold correction.
  • Robert Haassaw an earlier versiontrailerRaised compatibility concerns in #10, identified stale key-length documentation and requested splitting in #24, and discussed the retained 3.0 default in #36.
libpq: Add min/max_protocol_version connection options
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Add new protocol message to change GUCs for usage with future protocol-only GUCs (not this thread)
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #371 of 2 reviewers saw the final version

Combines the connection-option and protocol-3.2 components of #37, replacing numeric parsing with explicit supported strings in src/interfaces/libpq/fe-connect.c and revising tests and documentation. I disagree with the source attribution in thread #48977: its #583228 is an earlier ancestor, while this thread's matching April submission already contains minimum-version enforcement in fe-protocol3.c and the expanded negotiation documentation.

  • Robert Haassaw an earlier versiontrailerExamined exact-version versus range semantics in #24 and #26, and reconsidered compatibility after the default clarification in #36, before the final parser rewrite.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
libpq: Handle NegotiateProtocolVersion message differently
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Add new protocol message to change GUCs for usage with future protocol-only GUCs (not this thread)
LLM analysis, 99% suremodified before commitlight changesfrom patchset #371 of 2 reviewers saw the final version

Matches the negotiation component of #37, with light edits in src/interfaces/libpq/fe-connect.c and libpq-int.h renaming the state flag, setting it after successful parsing, and removing redundant error reporting; fe-protocol3.c matches exactly. I disagree with the source attribution in thread #48977: its #583228 predates this thread's matching April submission, which already includes the duplicate-message and truncated-message handling.

  • Robert Haassaw an earlier versiontrailerDiscussed negotiation compatibility in #10 and coordination with shared protocol infrastructure in #22, before the later negotiation-validation changes.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Add timingsafe_bcmp(), for constant-time memory comparison
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.10REL_16_STABLE16.14REL_15_STABLE15.18REL_14_STABLE14.23
LLM analysis, 100% surelanded as postedfrom patchset #370 of 1 reviewer saw the final version

The timingsafe_bcmp attachment in #37 has the same stable patch ID as the commit, including configure checks, port declarations, and the OpenSSL-backed fallback.

  • Jacob Championsaw an earlier versionLLM analysis, 99% sureQuestioned the fallback's constant-time guarantees in #27 and #31, prompting the subsequent OpenSSL implementation incorporated in #33.
docs: Update phrase on message lengths in the protocol
2 Apr 2025Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #371 of 1 reviewer saw the final version

Uses the message-length documentation correction from #37, with small wording changes in doc/src/sgml/protocol.sgml and a revised commit explanation.

  • Jelte Fennema-Niosaw the final versionLLM analysis, 84% sureAgreed in #9 with the rationale in #8 that explicit key-length fields add little validation value, supporting the documentation correction later posted in #37.

Feb 2025

2 commits
libpq: Trace all NegotiateProtocolVersion fields
24 Feb 2025Robert Haasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #331 of 1 reviewer saw the final version

The fe-trace.c attachment in #33 has an identical stable patch ID, adding tracing of every unsupported protocol-option name; #34 confirms its separate landing.

  • Robert Haassaw the final versioncommittercommitted the patch
libpq: Add PQfullProtocolVersion to exports.txt
24 Feb 2025Robert Haasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #331 of 1 reviewer saw the final version

Exactly matches the exports.txt attachment in #33, adding PQfullProtocolVersion at export ordinal 210; #34 confirms its separate landing.

  • Robert Haassaw the final versioncommittercommitted the patch

Jul 2024

1 commit
Move cancel key generation to after forking the backend
29 Jul 2024Heikki Linnakangasmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #180 of 1 reviewer saw the final version

Extends #18 by passing ProcSignal through EXEC_BACKEND's BackendParameters and restoring process-group SIGINT delivery in procsignal.c. Heikki explicitly identifies these fixes and comment edits in #19.

  • Jelte Fennema-Niosaw an earlier versiontrailerIdentified signaling issues in #5 and advocated spinlocks and atomic access in #15, before the spinlock revision and final EXEC_BACKEND fixes.

Credits across 10 commits

Author
Heikki LinnakangasLLM4
Jelte Fennema-Nio4
Daniel GustafssonLLM1
Reviewer
Robert Haascommitter5
Heikki Linnakangascommitter3
Jelte Fennema-Nio2
Noah Mischcommitter1
Co author
Jelte Fennema-Nio1
Committer
Heikki Linnakangas7
Robert Haas2
Daniel Gustafsson1
Noah Misch1

N LLM means N of the credits come from LLM analysis, not from commit trailers.