model-writtenrun 3525 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- While reviewing his backend fork/exec refactoring, Heikki Linnakangas noticed that pq_init() merely logged failure to enable nonblocking mode and continued using the connection #1.
- Heikki proposed replacing COMMERROR with FATAL and removing the obsolete recursion warning, explaining that initialization could safely report a fatal error, and planned to backpatch all supported versions #1.
- Heikki committed the attached code unchanged as f8c5317d00, with backports to all supported branches.
- Heikki confirmed that the fix had been committed #2.
- Daniel Gustafsson subsequently endorsed the change #3; his response came after the commit and therefore does not qualify for suggested review credit, and the thread ended with the fix landed.