Remove a FIXME and unused variables in Meson
Two meson patches.
One of them adds version gates to two LLVM flags (-frwapv,
-fno-strict-aliasing). I believe we moved the minimum LLVM version
recently, so these might not be necessary, but maybe it helps for
historictal reasons. If not, I'll just remove the comment in a different
patch.
Second patch removes some unused variables. Were they analogous to
things in autotools and the Meson portions haven't been added yet?
I was looking into adding LLVM JIT support to Meson since there is
a TODO about it, but it wasn't clear what was missing except adding some
variables into the PGXS Makefile.
--
Tristan Partin
Neon (https://neon.tech)
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
One of them adds version gates to two LLVM flags (-frwapv,
-fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
so these might not be necessary, but maybe it helps for historictal reasons.
If not, I'll just remove the comment in a different patch.Second patch removes some unused variables. Were they analogous to things in
autotools and the Meson portions haven't been added yet?I was looking into adding LLVM JIT support to Meson since there is a TODO
about it, but it wasn't clear what was missing except adding some variables
into the PGXS Makefile.
It looks like you have forgotten to attach the patches. :)
--
Michael
On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote:
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
One of them adds version gates to two LLVM flags (-frwapv,
-fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
so these might not be necessary, but maybe it helps for historictal reasons.
If not, I'll just remove the comment in a different patch.Second patch removes some unused variables. Were they analogous to things in
autotools and the Meson portions haven't been added yet?I was looking into adding LLVM JIT support to Meson since there is a TODO
about it, but it wasn't clear what was missing except adding some variables
into the PGXS Makefile.It looks like you have forgotten to attach the patches. :)
CLASSIC!
--
Tristan Partin
Neon (https://neon.tech)
Attachments:
v1-0001-Protect-adding-llvm-flags-if-found-version-is-not.patchtext/x-patch; charset=utf-8; name=v1-0001-Protect-adding-llvm-flags-if-found-version-is-not.patchDownload+7-5
v1-0002-Remove-some-unused-variables-in-Meson.patchtext/x-patch; charset=utf-8; name=v1-0002-Remove-some-unused-variables-in-Meson.patchDownload+0-7
On 14.03.24 06:13, Tristan Partin wrote:
One of them adds version gates to two LLVM flags (-frwapv,
-fno-strict-aliasing). I believe we moved the minimum LLVM version
recently, so these might not be necessary, but maybe it helps for
historictal reasons. If not, I'll just remove the comment in a different
patch.
We usually remove version gates once the overall minimum required
version is new enough. So this doesn't seem like a step in the right
direction.
Second patch removes some unused variables. Were they analogous to
things in autotools and the Meson portions haven't been added yet?
Hmm, yeah, no idea. These were not used even in the first commit for
Meson support. Might have had a purpose in earlier draft patches.