Fix the synopsis of pg_md5_hash

Started by Tatsuro Yamadaabout 2 years ago4 messageshackers
Jump to latest
#1Tatsuro Yamada
tatsuro.yamada.tf@nttcom.co.jp

Hi,

The synopsis of pg_md5_hash() seems wrong such as:
- s/int/bool/
- "errstr" is missing
So, I created a patch to fix them.

src/common/md5_common.c
==================================================
* SYNOPSIS #include "md5.h"
* int pg_md5_hash(const void *buff, size_t len, char *hexsum)
...
bool
pg_md5_hash(const void *buff, size_t len, char *hexsum, const char **errstr)
==================================================

Please find attached file.

Regards,
Tatsuro Yamada
NTT Open Source Software Center

Attachments:

fix_synopsis_of_pg_md5_hash.patchapplication/octet-stream; name=fix_synopsis_of_pg_md5_hash.patchDownload+2-1
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Tatsuro Yamada (#1)
Re: Fix the synopsis of pg_md5_hash

On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:

So, I created a patch to fix them.

Thanks, applied.

--
Daniel Gustafsson

#3Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#2)
Re: Fix the synopsis of pg_md5_hash

On Thu, Mar 14, 2024 at 09:32:55AM +0100, Daniel Gustafsson wrote:

On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:

So, I created a patch to fix them.

Thanks, applied.

Oops. Thanks.
--
Michael

#4Tatsuro Yamada
tatsuro.yamada.tf@nttcom.co.jp
In reply to: Michael Paquier (#3)
Re: Fix the synopsis of pg_md5_hash

Hi, Daniel and Michael,

On Thu, Mar 14, 2024 at 09:32:55AM +0100, Daniel Gustafsson wrote:

On 14 Mar 2024, at 07:02, Tatsuro Yamada <tatsuro.yamada@ntt.com> wrote:

So, I created a patch to fix them.

Thanks, applied.

Oops. Thanks.
--
Michael

Thank you guys!

Regards,
Tatsuro Yamada
NTT Open Source Software Center