Nov - Dec 2024

5 commits
Fix error code for referential action RESTRICT
2 Dec 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #25

Takes the RESTRICT error-code patch from the three-patch series in #25, preserving its ri_triggers.c changes. It additionally updates collate.icu.utf8.out because the accompanying tests had already landed.

doc: Improve description of referential actions
29 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #250 of 1 reviewer saw the final version

Commits only the documentation component of #25; the changes to doc/src/sgml/ddl.sgml and doc/src/sgml/ref/create_table.sgml match the submitted patch, including the subsequently reported typo.

  • jian hesaw an earlier versionLLM analysis, 90% sureHis examples and documentation criticism in #20 and proposed clarification in #23 prompted the separate explanation of NO ACTION versus RESTRICT, but he did not review the resulting documentation patch.
Add tests for foreign keys with case-insensitive collations
29 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #250 of 1 reviewer saw the final version

Takes the case-insensitive referential-action tests from #25, with the same SQL cases. Two expected diagnostic lines retain the old wording because the RESTRICT error-code change was committed later.

  • jian hesaw an earlier versionLLM analysis, 88% sureHe exercised case-insensitive RESTRICT, NO ACTION, and CASCADE behavior and supplied additional tests in #14 and #20, before Peter assembled the separate regression patch in #25.
Fix collation handling for foreign keys
15 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #171 of 1 reviewer saw the final version

The five-file implementation diff matches #17 modulo diff metadata and rebase context. The committed message fixes a typo and adds guidance that affected schemas must be adjusted before upgrading.

  • Jian Hesaw the final versiontrailerHe reviewed the initial implementation in #3 and #4, supplied detailed feedback on Peter's rewrite in #14 and #15, and reviewed the final version with a typo report and favorable response in #21 and #23.
Clarify a foreign key error message
7 Nov 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Clarifies the incompatible-type diagnostic in ATAddForeignKeyConstraint and updates expected output, without a matching attached patch. Peter explicitly says in #17 that he made this separate commit while addressing the diagnostic criticism in #15.

  • jian hesaw the final versionLLM analysis, 97% sureHe identified ambiguous column identification in the diagnostic and proposed distinguishing the tables in #15, which Peter applied to the analogous type-mismatch message as confirmed in #17.

Credits across 5 commits

Author
Peter EisentrautLLM4
Reviewer
jian he1
Reported by
jian he1
Paul A Jungwirth1
Committer
Peter Eisentraut5

N LLM means N of the credits come from LLM analysis, not from commit trailers.