fasthash32() returning uint64?

Started by Jeff Davisalmost 2 years ago2 messages
#1Jeff Davis
pgsql@j-davis.com

In hashfn_unstable.h, fasthash32() is declared as:

/* like fasthash64, but returns a 32-bit hashcode */
static inline uint64
fasthash32(const char *k, size_t len, uint64 seed)

Is the return type of uint64 a typo?

Regards,
Jeff Davis

#2John Naylor
johncnaylorls@gmail.com
In reply to: Jeff Davis (#1)
Re: fasthash32() returning uint64?

On Sat, Apr 6, 2024 at 3:47 AM Jeff Davis <pgsql@j-davis.com> wrote:

In hashfn_unstable.h, fasthash32() is declared as:

/* like fasthash64, but returns a 32-bit hashcode */
static inline uint64
fasthash32(const char *k, size_t len, uint64 seed)

Is the return type of uint64 a typo?

Yes it is, will fix, thanks!