Jun 2024

2 commits
Remove recordExtensionInitPriv[Worker]'s ownerId argument.
17 Jun 2024Tom Lanemaster17beta2REL_19_STABLE17beta2REL_18_STABLE17beta2REL_17_STABLE17beta2
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

No attachment removes recordExtensionInitPriv[Worker]'s ownerId argument and associated catalog lookups. Daniel proposed that cleanup in #40, and Tom agreed to commit it separately in #41.

  • Daniel Gustafssonsaw the final versionLLM analysis, 99% sureWhile reviewing #38, Daniel recommended removing unused owner-ID plumbing to avoid unnecessary catalog lookups in #40, and acknowledged the separate-commit plan in #42.
Improve tracking of role dependencies of pg_init_privs entries.
17 Jun 2024Tom Lanemaster17beta2REL_19_STABLE17beta2REL_18_STABLE17beta2REL_17_STABLE17beta2
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #381 of 3 reviewers saw the final version

The commit retains the REASSIGN OWNED implementation and tests from #38, but adds non-null assertions and empty-ACL handling in src/backend/catalog/aclchk.c, removes updateInitAclDependencies's unused ownerId parameter, and bumps catversion. These follow the review and agreement in #40 and #41.

  • Daniel Gustafssonsaw the final versionLLM analysis, 98% sureDaniel approved #12 in #13, reviewed and endorsed #38 in #40, and proposed the null-ACL assertions and owner-ID cleanup accepted in #41.
  • Hannu Krosingsaw an earlier versionLLM analysis, 98% sureHannu tested the landed implementation from #12 and supplied the REASSIGN OWNED reproducer in #19 that motivated the substantial follow-up in #38.
  • Robert Haassaw an earlier versionLLM analysis, 87% sureRobert examined the ownership gap in the implementation from #12 and proposed old-role-to-new-role substitution in #25, a direction implemented after further design discussion in #37 and #38.

Apr 2024

2 commits
Allow meson builds to run test_pg_dump test in installcheck mode.
29 Apr 2024Tom Lanemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1REL_16_STABLE16.5
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit removes the runningcheck restriction and its comment from src/test/modules/test_pg_dump/meson.build, exactly the change proposed inline in #5. No attachment contains this change; #15 confirms its landing.

  • Daniel Gustafssonsaw the final versionLLM analysis, 98% sureDaniel explicitly agreed with enabling the Meson test while discussing when to expose the additional buildfarm failures in #7.
Fix failure to track role dependencies of pg_init_privs entries.
29 Apr 2024Tom Lanemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #121 of 1 reviewer saw the final version

All seven files in #12 match the committed patch; the sole additional change is the catalog-version bump in src/include/catalog/catversion.h. Tom confirms pushing it after Daniel's approval in #14.

  • Daniel Gustafssonsaw the final versionLLM analysis, 100% sureDaniel reported successful adversarial testing of #10 in #11 and explicitly approved the revised tests and patch #12 in #13.

Credits across 4 commits

Author
Tom LaneLLM2
Committer
Tom Lane4
Michael Paquier1

N LLM means N of the credits come from LLM analysis, not from commit trailers.