Apr 2024

3 commits
SQL/JSON: Miscellaneous fixes and improvements
18 Apr 2024Amit Langotemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Lands the complete miscellaneous-fixes component of the three-patch series in #9; its diff matches that component modulo whitespace and hunk metadata. Changes cover doc/src/sgml/func.sgml, the wrapper enum cast in jsonpath_exec.c, and comments in jsonpath.h.

  • jian hesaw the final versionLLM analysis, 100% sureRequested terminology, comment, and enum-cast corrections in #4, then reviewed #5 and reported the broken documentation example in #6; subsequent changes to this component were light.
SQL/JSON: Fix issues with DEFAULT .. ON ERROR / EMPTY
18 Apr 2024Amit Langotemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: remaining sql/json patches (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #9

Lands the DEFAULT-expression component of #9, preserving the recursive validator in src/backend/parser/parse_expr.c and its regression tests with only formatting and SQL PATH capitalization changes; the commit credits jian he and Amit Langote as co-authors. The current verdict for thread #48026 agrees that it supplied the earlier bug report while this thread supplied the latest matching patch.

SQL/JSON: Improve some error messages
18 Apr 2024Amit Langotemaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #91 of 1 reviewer saw the final version

Lands the error-message component of #9, including column-name propagation and revised SQL/JSON diagnostics. The only additional non-whitespace code change is Assert(jtc->name != NULL) before copying the column name in src/backend/parser/parse_jsontable.c.

  • jian hesaw the final versionLLM analysis, 94% sureIdentified confusing wording and inconsistent SQLSTATEs in #4 and said the corrected work looked fine in #6, with only small refinements to this component afterward.

Credits across 3 commits

Author
Amit Langote2 LLM3
jian he1
Reported by
jian he3
Committer
Amit Langote3

N LLM means N of the credits come from LLM analysis, not from commit trailers.