model-writtenrun 3397 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- David Steele reported that arbitrary INCREMENTAL.* files could make pg_combinebackup fail during restore and suggested rejecting such names during backup or recording incremental information in the manifest #1.
- Robert Haas proposed recognizing incremental filenames only in relation-data locations, while David supported protecting the root of PGDATA and insisted that the restore failure needed fixing or documenting #2 #3.
- David Steele and Stefan Fercot favored using the manifest for additional incremental metadata, but Robert Haas argued that making it essential for restoration would change established expectations and suggested separate stub lists instead #3 #4 #5.
- Robert Haas agreed to investigate the filename failure, while the broader stub-elision discussion remained exploratory: Stefan Fercot acknowledged the timing constraints, and Robert explained why per-directory stub lists fit the existing traversal and could limit memory use #6 #7 #8.
- Robert Haas submitted a patch that reconstructs INCREMENTAL.* files only in expected relation-data locations and copies them normally elsewhere, with a regression test placing INCREMENTAL.config at the root of PGDATA #9.
- David Steele tested and accepted the patch, while noting that rejecting conflicting filenames during backup would still be preferable for relation-data directories; he considered that remaining case sufficiently rare #10.
- Robert Haas committed the patch with only whitespace changes as 9e72f6bfae and announced completion #11; David acknowledged the result in the final reply #12, leaving manifest redesign and stub elision outside this fix.