Jul 2024

2 commits
Improve performance of binary_upgrade_set_pg_class_oids().
3 Jul 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #110 of 3 reviewers saw the final version

Matches the complete performance patch in #11, including startup collection, the sorted array, binary search, and typedef registration. Commit edits rename structure fields and their uses in src/bin/pg_dump/pg_dump.c and remove unused SQL column aliases.

  • Corey Huinkersaw an earlier versiontrailerIn #2, he estimated cache memory consumption and endorsed the tradeoff, before #10 moved collection from lazy initialization into startup.
  • Michael Paquiersaw an earlier versiontrailerIn #3, he endorsed the caching design while explicitly disclaiming detailed inspection or testing, before the initialization refactoring in #10.
  • Daniel Gustafssonsaw an earlier versiontrailerHe discussed the design in #4 and reported a favorable read-through with comment requests in #8, before the initialization refactoring in #10.
Remove is_index parameter from binary_upgrade_set_pg_class_oids().
3 Jul 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #111 of 1 reviewer saw the final version

The complete prerequisite patch in #11 matches the commit diff apart from offsets and index hashes: src/bin/pg_dump/pg_dump.c drops is_index from the declaration, definition, and callers and uses relkind instead.

  • Daniel Gustafssonsaw the final versiontrailerHe proposed removing is_index in #4 and reviewed the resulting patch in #8, after which this prerequisite underwent only rebasing.

Credits across 2 commits

Author
Nathan BossartLLM2
Reviewer
Daniel Gustafsson2
Corey Huinker1
Michael Paquier1
Committer
Nathan Bossart2

N LLM means N of the credits come from LLM analysis, not from commit trailers.