model-writtenrun 2904 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane opened the thread with six patches in #1, replacing repetitive grammar string actions with Bison location values and YYLLOC_DEFAULT to reduce his clang compilation time from 104 seconds to under one second; statement-local allocation addressed the resulting string-lifetime problem.
- Andres Freund explained that Bison coverage already worked and investigated scanner coverage exclusions in #2 and #4, while Tom noted unreliable flex line mappings in #3 and #5, leaving test coverage a concern.
- Tom separately identified that parse.pl split IDENT's precedence declaration in #6; John Naylor later tested rejoining it and supported retaining CSTRING on that same precedence level in #8.
- After a July rebase in #7, John reviewed the initial cleanup patches in #9; Tom adopted his documentation suggestions and added removal of the redundant check_rules.pl script in #10.
- Peter Eisentraut approved landing the bulky indentation cleanup separately in #12, and it landed unchanged from #10 as 97add39c03.
- Performance testing revealed that the revised preprocessor initially ran slower and leaked more memory, so Tom expanded the remaining series in #13 with data-type ownership fixes, local storage for lexer strings, and assorted leak cleanup; he reported roughly ten percent faster execution and no leaks detected by the regression tests.
- Tom identified a missing static qualifier for progname in #14 and incorporated it with the October rebase in #15, preserving the design.
- John reviewed the main changes in #17, measured a GCC compilation speedup, endorsed statement-local memory management, and requested version-specific explanatory wording; Tom adopted those wording suggestions but declined an additional lexer comment because he found no useful placement in #18.
- The documentation and validation patch, check_rules.pl removal, and parse.pl cleanup from #15 landed as 00b0e7204d, 293fd24425, and 6b00549944, with only a comment adjustment in the last.
- The string-management rewrite, util.c extraction, and statement-local allocator from #15 landed as a542d5614b, f18231e817, and 1acd0f5527, with only explanatory wording changes to the rewrite and allocator.
- Tom resent the three remaining leak-cleanup patches in #18, explaining that the landed allocator still leaked more than the old implementation and that completing the remaining sequence reduced measured regression-test leakage to zero.
- The separately discussed precedence repair from #6 and #8 landed as 9812138593, keeping CSTRING and IDENT on one precedence line without changing the generated parser's behavior.
- Alexander Lakhin supplied three Valgrind reproductions involving cursor state, unmatched subscripts, and a null function name in #19; Tom fixed them in 9b4bf51690 and explained in #20 that their limited impact did not warrant backpatching.
- Tom rebased the remaining three patches around intervening changes in #21, without substantive changes.
- Alexander's next testing round in #22 exposed unmatched-right-brace and non-array-indexing crashes, fixed by 1fed234f9f; Tom declined to special-case directory inclusion errors in #23 because the poor diagnostic originated in flex and the proposed workaround would address only one error cause.
- John recommended committing the final three patches after reviewing them and inspecting grammar coverage in #24; the data-type cleanup landed with an expanded ownership comment as 0e6060790d, while lexer-token storage and assorted leak cleanup landed unchanged from #21 as 85312d95e9 and 2b41de4a5b.
- Tom confirmed completion in #25, explained that static progname kept its allocation reachable for Valgrind, and left broader coverage improvements for future work; all submitted patches had landed.