model-writtenrun 2363 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Anton A. Melnikov proposed replacing hardcoded control-file paths throughout C code with XLOG_CONTROL_FILE #1; Daniel Gustafsson supported the searchability benefit #2, while Michael Paquier and Daniel agreed this cleanup should wait for PostgreSQL 18 development #3 #4.
- Peter Eisentraut questioned the macro's name #6, prompting Anton to suggest PG_CONTROL_FILE with a compatibility alias #7 #9; Robert Haas preferred one existing identifier, and Tom Lane opposed piecemeal renaming of internal xlog symbols #11 #12.
- Daniel summarized consensus for consistent XLOG_CONTROL_FILE usage but questioned the revised comment and error-message readability #14; Kyotaro Horiguchi additionally questioned exposing xlog_internal.h to postmaster.c #15, leading Anton to revise the wording and add definitions to xlogdefs.h #16.
- Kyotaro proposed a broader solution that extracted file and path definitions into xlogfilepaths.h, supplying that prerequisite alongside an adapted version of Anton's patch #17; Anton then supplied a delta separating size-related macros into xlogfilesize.h #18.
- After a gap of more than six months, Anton rebased and combined the header extraction, size-header delta, and macro substitutions into a three-patch series #19, followed by another master rebase #20.
- Near feature freeze, Fujii Masao deferred the two header reorganizations because they lacked clear consensus and prepared a standalone macro-substitution patch, fixing a comment typo and remaining hardcoded paths while retaining xlog_internal.h #21.
- Anton approved the standalone patch and proposed extending the cleanup to Perl tests through a header-derived controlfile accessor #22.
- Fujii deferred the Perl extension because converting only the control-file path would leave similar hardcoded values such as pg_wal and a broader cleanup needed more time #23; Anton agreed to revisit those cases together later #24.
- Fujii committed #21 unchanged as 173c97812f and announced the push #25; Anton acknowledged completion #26, leaving the C cleanup landed and the header reorganizations and Perl extension deferred.