May 2024

1 commit
Remove option to fall back from direct to postgres SSL negotiation
16 May 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #541 of 3 reviewers saw the final version

Applying #54 to the commit's parent reproduces the committed files except for removal of one redundant Assert in src/interfaces/libpq/fe-connect.c. Jacob identified that assertion in #55, and Heikki confirmed its removal in #58.

  • Jelte Fennema-Niosaw an earlier versiontrailerJelte questioned first-character option comparisons in #42, before #54 reworked SSL method selection.
  • Robert Haassaw an earlier versiontrailerRobert reported reading the patch without finding major problems in #45, before the method-selection refactoring in #54; his later #56 requested timely commitment.
  • Jacob Championsaw the final versiontrailerJacob requested simpler method selection in #51, then reviewed #54 positively and identified the redundant assertion in #55.

Apr 2024

4 commits
Reject SSL connection if ALPN is used but there's no common protocol
29 Apr 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #230 of 1 reviewer saw the final version

Applying #23 to the commit's parent exactly reproduces both changed files: src/backend/libpq/be-secure-openssl.c and src/interfaces/libpq/fe-secure-openssl.c.

  • Jacob Championsaw an earlier versionLLM analysis, 91% sureJacob identified the missing handshake-level rejection and specified the required alert in #10, prompting #23; his attached-patch testing in #28 occurred after commitment and is excluded.
libpq: Enforce ALPN in direct SSL connections
29 Apr 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #70 of 1 reviewer saw the final version

Compared with #7, the commit moves enforcement entirely into open_client_SSL() in src/interfaces/libpq/fe-secure-openssl.c and limits it to direct connections. It removes the proposed ssl_alpn_used field and the fe-connect.c check, following Michael's question in #9.

  • Michael Paquiersaw an earlier versiontrailerMichael reviewed #7 in #9 and questioned checking ALPN outside direct mode, after which the enforcement logic was consolidated without another posted patch.
libpq: If ALPN is not used, make PQsslAttribute(conn, "alpn") == ""
29 Apr 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Michael reported the documented empty-string versus actual NULL mismatch in PQsslAttribute() in #9, and Heikki confirmed the fix in #25. No attachment contains this change; the commit adjusts fe-secure-openssl.c and psql's printSSLInfo() to preserve its 'none' display.

  • Michael Paquiersaw the final versionLLM analysis, 98% sureMichael identified the exact PQsslAttribute() contract violation in #9, leading to the small correction; his later acknowledgment in #26 is not counted as pre-commit review.
Fix documentation and comments on what happens after GSS rejection
28 Apr 2024Heikki Linnakangasmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #141 of 1 reviewer saw the final version

Applying #14 to the commit's parent yields the committed documentation exactly; the only remaining difference is correcting 'negotiatied' and rewrapping its comment in src/interfaces/libpq/fe-connect.c, as requested in #15.

  • Jacob Championsaw the final versionLLM analysis, 100% sureJacob tested the behavior and identified misleading documentation in #13, then endorsed #14 with a spelling correction in #15.

Credits across 5 commits

Author
Heikki LinnakangasLLM4
Reviewer
Jacob Champion1
Jelte Fennema-Nio1
Michael Paquier1
Robert Haas1
Reported by
Jacob Champion3
Michael Paquier1
Committer
Heikki Linnakangas5

N LLM means N of the credits come from LLM analysis, not from commit trailers.