Jul 2024

1 commit
Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
1 Jul 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #33 of 4 reviewers saw the final version

Both hunks in src/bin/pg_upgrade/dump.c exactly match the unconditional --no-sync additions in #3; the committed diff contains no additional changes 6e16b1e420.

  • Peter Eisentrautsaw an earlier versiontrailerPeter approved the initial patch #2, before removal of the version guards changed behavior for upgrades from older clusters #3.
  • Tom Lanesaw the final versiontrailerTom endorsed Nathan's revised patch with a +1 #4.
  • Michael Paquiersaw the final versiontrailerMichael endorsed the revised patch and suggested considering a backpatch because the flushes impose costs without benefit #5.
  • Daniel Gustafssonsaw the final versiontrailerDaniel characterized the change as a useful small improvement and agreed its likely speedup did not warrant changing stable branches #7.

Credits across 1 commit

Author
Nathan BossartLLM1
Reviewer
Daniel Gustafsson1
Michael Paquier1
Peter Eisentraut1
Tom Lane1
Committer
Nathan Bossart1

N LLM means N of the credits come from LLM analysis, not from commit trailers.