Feb 2026

1 commit
Use CXXFLAGS instead of CFLAGS for linking C++ code
26 Feb 2026Tom LaneREL_17_STABLE17.10REL_16_STABLE16.14REL_15_STABLE15.18REL_14_STABLE14.23
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

This supplied candidate backpatches 365b5a345b, changing CFLAGS to CXXFLAGS in src/backend/jit/llvm/Makefile after Tom Lane's renewed failure report in #13. Its commit message explicitly credits Peter Eisentraut as author; no attached patchset contains this change.

  • Tom Lanesaw the final versioncommittercommitted the patch

Sep 2024

1 commit
Add further excludes to headerscheck
24 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The five contrib/isn exclusions in src/tools/pginclude/headerscheck exactly implement Peter's inline patch in #12, following Thomas Munro's warning report in #11. This change appears in no attached patchset.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas reported headerscheck warnings for the contrib/isn files in #11, prompting the inline exclusion patch in #12.

Jul - Aug 2024

8 commits
Use CXXFLAGS instead of CFLAGS for linking C++ code
4 Aug 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Changes the LLVM JIT link command in src/backend/jit/llvm/Makefile from CFLAGS to CXXFLAGS, exactly addressing Tom Lane's diagnosis in #9. Peter confirmed the fix in #10; no attached patchset contains it.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom reported buildfarm failures and identified CFLAGS being passed to the C++ linker in #9, directly motivating the committed correction.
Add -Wmissing-variable-declarations to the standard compilation flags
3 Aug 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

The stable patch ID matches the warning-enablement patch in #7, including configure, configure.ac, meson.build, and the ECPG and pg_bsd_indent exceptions. The same patch also appears unchanged in #4.

  • Andres Freundsaw the final versiontrailerAndres supported and reviewed the series in #5, and its warning-enablement patch remained unchanged through #7 and commitment.
Include bison header files into implementation files
2 Aug 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #7

The stable patch ID exactly matches the generated-Bison-header inclusion patch in #7, covering eight parser files and moving the cube YYSTYPE definition before its header include.

Fix -Wmissing-variable-declarations warnings for float.c special case
25 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

Preserves all five float.c extern declarations from #4. The only code-diff addition is an explanatory comment saying that the declarations silence -Wmissing-variable-declarations.

  • Andres Freundsaw the final versiontrailerAndres criticized the existing reliance on external linkage under LTO in #5 while treating that issue as outside this patch, which subsequently gained only a comment.
Add extern declarations for Bison global variables
25 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #41 of 1 reviewer saw the final version

Preserves the Bison global-variable declarations from #4 across all eight parser files. Each declaration block gains a comment identifying -Wmissing-variable-declarations as its purpose.

  • Andres Freundsaw the final versiontrailerAndres reviewed the series and expressed displeasure with its workaround in #5, with only explanatory comments added before this commit.
Move all extern declarations for GUC variables to header files
24 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the GUC declaration patch in #4, moving ad-hoc extern declarations into headers and retaining the conditional access/syncscan.h include in guc_tables.c.

  • Andres Freundsaw the final versiontrailerAndres proposed an unconditional include in #5, and Peter explained retaining the conditional include for future include-cleaner clarity in #6.
Move extern declarations for EXEC_BACKEND to header files
23 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the EXEC_BACKEND patch in #4, moving declarations out of launch_backend.c into four headers and making its PMSignalState pointer consistently volatile.

  • Andres Freundsaw the final versiontrailerAndres questioned extending volatile but acknowledged that this did not worsen the existing situation in #5, and Peter defended consistency in #6.
Get rid of a global variable
23 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the bootstrap checksum patch in #4, replacing the global bootstrap_data_checksum_version with a local variable passed through BootStrapXLOG and InitControlFile.

  • Andres Freundsaw the final versiontrailerAndres reviewed and supported the series in #5, although his reply contains no separate comment on the checksum-variable patch, which landed unchanged.

Jul 2024

4 commits
Convert some extern variables to static
2 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the static-linkage conversions in #4, including contrib/isn tables, frontend variables, and backend helpers. Andres's proposed additional const qualifications were left for separate work, as explained in #6.

  • Andres Freundsaw the final versiontrailerAndres examined table mutability and progname linkage in #5, and Peter explained the existing progname convention and separate const follow-up in #6.
Improve some global variable declarations
2 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the global-declaration cleanup in #4: ShmemLock and redirection_done move into headers, and ShmemBackendArray gains NON_EXEC_STATIC.

  • Andres Freundsaw the final versiontrailerAndres reviewed and supported the series in #5, with no separate requested change to this global-declaration cleanup, which landed unchanged.
Add missing includes for some global variables
2 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The stable patch ID matches the four missing includes in pqcomm.c, globals.c, guc_tables.c, and tuplesort.c from #4. That patch was also present unchanged in #1.

  • Andres Freundsaw the final versiontrailerAndres reviewed and supported the series in #5, with no separate objection to this missing-includes patch, which landed unchanged.
Remove useless extern keywords
1 Jul 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #4

The stable patch ID exactly matches the extern-keyword cleanup in #4, removing extern from six function definitions across basebackup_incremental.c, fd.c, bbstreamer_inject.c, and bbstreamer_tar.c.

Credits across 14 commits

Author
Peter Eisentraut11 LLM12
Reviewer
Andres Freund9
Tom Lanecommitter1
Reported by
Tom Lane2
Thomas Munro1
Committer
Peter Eisentraut13
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.