model-writtenrun 3146 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed enabling -Wmissing-variable-declarations and supplied seven cleanup patches in #1, aiming to catch missing global-variable declarations that escaped PGDLLIMPORT checks and could complicate future threading work.
- Heikki Linnakangas supported moving the GUC and miscellaneous declarations into headers in #2; Peter then traced several ad-hoc declarations to EXEC_BACKEND machinery and identified inconsistencies in NON_EXEC_STATIC usage in #3.
- Peter's revised series in #4 replaced provisional extern declarations with proper headers, passed the bootstrap checksum setting through function arguments, fixed EXEC_BACKEND declarations, and omitted the warning for C++; he left open whether to accept temporary Bison declarations or wait for pure parsers.
- Andres Freund reviewed the revised series in #5, proposing stronger const qualifications, questioning progname linkage and additional volatile usage, suggesting an unconditional include, and warning that float.c's reliance on external linkage could fail under LTO.
- The first landing took the extern-keyword cleanup unchanged as 3fb59e789d, followed by unchanged static-linkage conversions as 720b0eaae9, global-declaration cleanup as 8f8bcb8883, and missing includes as 881455e57b, all from #4.
- Peter announced that initial landing in #6, leaving const additions to Andres's separate work, explaining that progname linkage followed each program's needs, and retaining consistent volatile qualification and the conditional include.
- The remaining structural cleanups from #4 landed unchanged: the bootstrap checksum argument conversion as 935e675f3c, EXEC_BACKEND header declarations as d3cc5ffe81, and GUC header declarations as 774d47b6c0.
- Peter accepted the temporary Bison and float.c declaration workarounds from #4, adding only explanatory comments before committing ab61c40bfa and 37c6923cf3; conversion to pure parsers remained a longer-term alternative.
- Before activating the warning, Peter found that Bison versions before 3.4 omitted declarations for yylval and sometimes yylloc from generated implementation files, so #7 paired the remaining warning patch with explicit generated-header includes.
- Both remaining patches from #7 landed unchanged as 9fb855fe1a and 6618891256, and Peter announced completion in #8.
- Tom Lane then reported mixed-compiler buildfarm failures and diagnosed CFLAGS being passed to the C++ linker in #9; Peter corrected the LLVM JIT Makefile in 365b5a345b and confirmed success in #10.
- Thomas Munro reported headerscheck warnings for contrib/isn data headers in #11, prompting Peter's inline exclusion patch in #12, which landed as 59f0eea7b0.
- At the thread's final message, #13, Tom reported equivalent C++ linking failures on older branches and requested backpatching after release freeze; the supplied candidate 231570d335 records that subsequent backpatch of Peter's fix, with no attached series still awaiting commitment.