Sep 2024

11 commits
Introduce framework for parallelizing various pg_upgrade tasks.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #331 of 5 reviewers saw the final version

Matches the framework attachment in #33 with light edits in src/bin/pg_upgrade/task.c: clearer introductory wording, correction of 'inital', and simplified cleanup without a redundant null check; the commit explanation was also refined.

  • Jeff Davissaw an earlier versiontrailerJeff questioned asynchronous versus multiprocess complexity and suggested connection reuse and documentation changes in #2, before the reusable framework and later polling changes.
  • Robert Haassaw an earlier versiontrailerRobert endorsed asynchronous communication and questioned the claimed use of system() in #5, before substantial framework revisions.
  • Daniel Gustafssonsaw the final versiontrailerDaniel proposed error-handling and query-ownership improvements in #9, then tested the final series and identified its comment typo in #34.
  • Ilya Gladyshevsaw an earlier versiontrailerIlya tested and repeatedly reviewed the framework, most recently endorsing #31 and proposing the polling relocation in #32, which was implemented with further control-flow changes in #33.
  • Corey Huinkersaw an earlier versiontrailerCorey judged the mechanism solid and advocated pipelining in #22 and #24, before query batching and connection-readiness handling changed.
pg_upgrade: Parallelize retrieving relation information.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #332 of 2 reviewers saw the final version

Matches the relation-and-logical-slot attachment in #33 except for removal of the relation query's trailing semicolon after ORDER BY 1 in src/bin/pg_upgrade/info.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel suggested PQExpBuffer query construction in #9 and read and tested the final series in #34, before only a redundant SQL separator was removed.
  • Ilya Gladyshevsaw the final versiontrailerIlya's testing and reviews culminated in #32, after which this consumer changed only by removal of a redundant SQL separator.
pg_upgrade: Parallelize subscription check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete subscription-check attachment in #33 has the same stable patch ID as this commit, parallelizing table-state checks while retaining the once-only replication-origin query in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel requested named result-column lookups in #9 and later read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.
pg_upgrade: Parallelize retrieving loadable libraries.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #332 of 2 reviewers saw the final version

Matches the loadable-library attachment in #33 except for removal of a trailing semicolon from its pg_proc query in src/bin/pg_upgrade/function.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel read and tested the final series in #34, after reviewing its earlier form in #9, and only a redundant SQL separator changed afterward.
  • Ilya Gladyshevsaw the final versiontrailerIlya's testing and reviews culminated in #32, after which this consumer changed only by removal of a redundant SQL separator.
pg_upgrade: Parallelize retrieving extension updates.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete extension-update attachment in #33 has the same stable patch ID as this commit, preserving the callback that writes update_extensions.sql in src/bin/pg_upgrade/version.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.
pg_upgrade: Parallelize data type checks.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete data-type-check attachment in #33 has the same stable patch ID as this commit, including callback-local state, failure reporting, and per-check task registration in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya identified the broken failure flag and proposed local callback state in #20, then reviewed the revised series in #29 and #32.
pg_upgrade: Parallelize contrib/isn check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete contrib/isn attachment in #33 has the same stable patch ID as this commit, converting the bigint-passing compatibility check in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.
pg_upgrade: Parallelize postfix operator check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete postfix-operator attachment in #33 has the same stable patch ID as this commit, including its result callback and UpgradeTaskReport usage in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.
pg_upgrade: Parallelize incompatible polymorphics check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #332 of 2 reviewers saw the final version

Matches the polymorphics attachment in #33 except for removal of the query's trailing semicolon in src/bin/pg_upgrade/check.c; the framework supplies the separator.

  • Daniel Gustafssonsaw the final versiontrailerDaniel read and tested the final series in #34, after reviewing its earlier form in #9, and only a redundant SQL separator changed afterward.
  • Ilya Gladyshevsaw the final versiontrailerIlya's testing and reviews culminated in #32, after which this consumer changed only by removal of a redundant SQL separator.
pg_upgrade: Parallelize WITH OIDS check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete WITH OIDS attachment in #33 has the same stable patch ID as this commit, preserving process_with_oids_check and its task setup in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.
pg_upgrade: Parallelize encoding conversion check.
16 Sep 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #332 of 2 reviewers saw the final version

The complete encoding-conversion attachment in #33 has the same stable patch ID as this commit, including its UpgradeTaskReport callback and query registration in src/bin/pg_upgrade/check.c.

  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed the earlier series in #9 and explicitly read, tested, and endorsed the final series in #34.
  • Ilya Gladyshevsaw the final versiontrailerIlya tested and reviewed successive series in #17, #20, #29, and #32, with this consumer unchanged after his latest review.

Jul 2024

1 commit
pg_upgrade: Move live_check variable to user_opts.
26 Jul 2024Nathan Bossartmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surelanded as postedfrom patchset #141 of 1 reviewer saw the final version

The standalone live_check attachment in #14 has the same stable patch ID as this commit across all six pg_upgrade source files; Nathan confirmed its landing in #16.

  • Daniel Gustafssonsaw the final versiontrailerDaniel recommended landing the refactoring independently in #11 and explicitly approved its standalone final version in #15.

Credits across 12 commits

Author
Nathan BossartLLM12
Reviewer
Daniel Gustafsson12
Ilya Gladyshev11
Corey Huinker1
Jeff Davis1
Robert Haas1
Committer
Nathan Bossart12

N LLM means N of the credits come from LLM analysis, not from commit trailers.