model-writtenrun 3311 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed replacing three compile-time node-testing switches with run-time parameters in #1, allowing tests without recompilation while preserving legacy symbols as default selectors.
- Ranier Vilela and Tom Lane questioned including developer-only checks in production builds in #2, #3, and #5; Peter defended easier access to testing and compared existing debug parameters in #4.
- Andres Freund identified code-density costs and potentially measurable READ_LOCATION_FIELD overhead in #6, suggesting unlikely() annotations and discussing privileged access and a single multi-value setting.
- Peter revised the patch in #7 to compile the checks only when assertions, DEBUG_NODE_TESTS_ENABLED, or legacy switches enable them, added documentation, and restricted the parameters to PGC_SUSET while retaining three booleans.
- Peter also floated combined settings, cost-based levels, and enabling cheap checks by default in #7; Tom endorsed the revised production exclusion and considered combining the booleans unnecessary in #8, while raising broader treatment of existing debug switches.
- At the thread's last message, Peter favored proceeding with the revised patch and leaving further refinements to follow-up work in #9.
- Peter subsequently committed #7 unchanged apart from rebasing as a292c98d62, completing the submitted change without incorporating the optional broader refinements.