Sep 2024

7 commits
SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY steps
9 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.0
LLM analysis, 100% surelanded as postedfrom patchset #47

The stable patch-id exactly matches #47, including the ExecInitJsonExpr() optimization and ExecEvalJsonExprPath() fallbacks for omitted jump targets. The commit credits Jian He and Amit Langote as authors.

SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.0
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Extracts the default-ON-ERROR component of #44, preserving its parse_expr.c and ruleutils.c changes. Regression tests replace EXPLAIN VERBOSE with CREATE VIEW and view-definition inspection, as explained in #46 and #47.

  • jian hesaw the final versionLLM analysis, 99% sureIn #43, he identified duplicated tests and inconsistent intermediate deparsing output in #42, followed only by patch reordering and test changes for this component.
SQL/JSON: Fix JSON_TABLE() column deparsing
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.0
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Extracts the column-deparsing component of #44 with unchanged ruleutils.c logic. Its sqljson_jsontable regression tests use CREATE VIEW and view-definition inspection instead of EXPLAIN VERBOSE to address the buildfarm failures reported in #46.

  • Jian Hesaw the final versiontrailerHe reviewed the deparsing tests in #43, prompting patch reordering and test corrections, with only further test changes before the second landing.
SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY steps
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.0
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #44

The commit's stable patch-id exactly matches the executor-optimization attachment in #44, one component of its four-patch series. Its Author trailers credit Jian He and Amit Langote; it does not contain the later LLVM fix in #47.

SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Exactly matches the default-ON-ERROR attachment in #44, extracting that component of the series unchanged. It changes parse_expr.c and ruleutils.c to use JSON_BEHAVIOR_EMPTY_ARRAY and includes the submitted tests.

  • jian hesaw the final versionLLM analysis, 99% sureIn #43, he identified duplicated tests and inconsistent intermediate deparsing output in #42, leading to patch reordering and test adjustments without changing this fix's logic.
SQL/JSON: Fix JSON_TABLE() column deparsing
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Its stable patch-id exactly matches the column-deparsing attachment in #44, a separately committed component of that series. The ruleutils.c changes and regression tests are unchanged.

  • Jian Hesaw the final versiontrailerHe reviewed the deparsing tests in #43, prompting the ordering and test corrections in #44, with no subsequent substantive change to this component.
Update comment about ExprState.escontext
6 Sep 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.0
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #441 of 1 reviewer saw the final version

Exactly matches the execnodes.h comment attachment carried unchanged through #41, #42, and #44. The latest matching submission is the source; the other series components were committed separately.

  • jian hesaw the final versionLLM analysis, 100% sureHe explicitly said the comment patch in #42 looked good in #43, after originally identifying the misleading wording in #37.

Jul 2024

7 commits
SQL/JSON: Some fixes to JsonBehavior expression casting
30 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #36

Takes the JsonBehavior-casting component of #36, with only comment wrapping and regression-test comment corrections. Its Author trailers credit Jian He, whose tests came from #27, alongside Amit Langote.

SQL/JSON: Fix casting for integer EXISTS columns in JSON_TABLE
30 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #36

Takes the integer-EXISTS component of #36, renames check_domain to exists_check_domain, documents the exists_* fields, and removes some redundant domain tests. The commit credits Jian He and Amit Langote as authors.

SQL/JSON: Remove useless code in ExecInitJsonExpr()
26 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #351 of 1 reviewer saw the final version

Exactly matches the dead-jump-removal attachment in #35, separately extracting that series component. It deletes the redundant unconditional jump in ExecInitJsonExpr().

  • jian hesaw the final versionLLM analysis, 94% sureHe identified the unnecessary executor jump while reviewing #31 in #32, and the resulting patch simply removes that dead code.
SQL/JSON: Respect OMIT QUOTES when RETURNING domains over jsonb
26 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #350 of 1 reviewer saw the final version

Exactly matches the OMIT QUOTES attachment in #35, including its corrected domain-over-jsonb test. This series component passes the quote-handling flag through populate_domain() in jsonfuncs.c.

  • jian hesaw an earlier versionLLM analysis, 94% sureHis domain-over-jsonb and quote-handling examples in #33 exposed problems in #31, before the populate_domain() implementation and corrected regression test were added.
SQL/JSON: Improve error-handling of JsonBehavior expressions
26 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #350 of 1 reviewer saw the final version

Extracts the error-reporting half of the third attachment in #35: execExprInterp.c preserves coercion error details and reports which behavior expression failed. Comments and expected results were adjusted for committing it ahead of the remaining casting patches.

  • jian hesaw an earlier versionLLM analysis, 98% sureHe challenged returning NULL for failed behavior coercions in #29 and supplied further domain-error examples in #33, before the error-reporting implementation was expanded and split.
SQL/JSON: Fix error-handling of some JsonBehavior expressions
26 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #350 of 1 reviewer saw the final version

Extracts the error-capture half of the third attachment in #35, adding ErrorSaveContext handling and COERCION_FINISH steps. It additionally initializes those steps' result pointers and resets error_occurred, leaving detailed error reporting for the following commit.

  • jian hesaw an earlier versionLLM analysis, 98% sureHis domain-constraint example in #33 showed that #31 failed to route a behavior-expression error through the intended handling, prompting the later executor changes.
SQL/JSON: Rethink c2d93c3802b
17 Jul 2024Amit Langotemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 3 reviewers saw the final version

Implements the constructor rollback and assignment-cast replacement from #23. The committed parse_expr.c adds explanatory comments and uses COERCE_IMPLICIT_CAST instead of the attachment's COERCE_EXPLICIT_CAST display form.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 98% sureHis post-commit review in #20 questioned typmod-dependent casting and variable initialization in #19, prompting the assignment-cast redesign.
  • Tom Lanesaw an earlier versionLLM analysis, 98% sureIn #21, he identified domain-coercion inconsistencies and redundant syscache lookups in the implementation from #19, which the replacement removes.
  • jian hesaw the final versionLLM analysis, 100% sureHe reported that #23 worked and explained its assignment-cast behavior in #24, with only comments and cast-display form changed afterward.

Jun 2024

2 commits
SQL/JSON: Always coerce JsonExpr result at runtime
28 Jun 2024Amit Langotemaster17beta3REL_19_STABLE17beta3REL_18_STABLE17beta3REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #190 of 1 reviewer saw the final version

Takes the runtime-coercion component of #19, adding a catalog-version bump in catversion.h and correcting comments and formatting. The constructor component was committed separately.

  • Jian Hesaw an earlier versiontrailerHe tested domain and DEFAULT failures in #11, #14, and #15, then reviewed stale references in #18, but substantive OMIT QUOTES routing changes followed in #19.
SQL/JSON: Fix coercion of constructor outputs to types with typmod
28 Jun 2024Amit Langotemaster17beta3REL_19_STABLE17beta3REL_18_STABLE17beta3REL_17_STABLE17beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #191 of 1 reviewer saw the final version

Its stable patch-id exactly matches the constructor attachment in #19, extracting that component unchanged. It adds typmod-sensitive constructor coercion in parse_expr.c and sqljson regression tests.

  • Jian Hesaw the final versiontrailerHis domain and typmod review in #11 and follow-up testing in #15 covered the earlier combined patch, after which the constructor component underwent only separation and light cleanup.

Credits across 16 commits

Author
Amit Langote12 LLM16
jian he4
Reviewer
jian he4
Reported by
jian he9
Alvaro Herrera2
Committer
Amit Langote16

N LLM means N of the credits come from LLM analysis, not from commit trailers.