model-writtenrun 3288 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Nathan Bossart proposed removing unused return values and output-count parameters from pg_dump helpers after discovering that their results were already stored in a separate hash table #1.
- Neil Conway welcomed the cleanup but suggested renaming the helpers and allocating objects individually; Nathan suggested collectXXX names while favoring retaining bulk allocations, and Neil accepted the naming suggestion without insisting on allocation changes #2 #3 #4.
- Tom Lane favored retaining getXXX names and cautioned that individual allocations would require hundreds of edits, complicate back-patching and potentially affect static-analysis leak reports #5.
- Nathan decided to commit the original patch when PostgreSQL 18 development opened, leaving further adjustments for separate consideration; Daniel Gustafsson subsequently approved that version and reported passing tests #6 #7.
- Nathan committed the sole patchset unchanged as 8213df9eff and confirmed completion in the final message, leaving no submitted patch outstanding #1 #8.