Nov 2025

1 commit
Special case C_COLLATION_OID in pg_newlocale_from_collation().
5 Nov 2025Jeff Davismaster19beta1REL_19_STABLE19beta1REL_18_STABLE18.1
LLM analysis, 100% surelanded as postedfrom patchset #321 of 1 reviewer saw the final version

The changes in src/backend/utils/adt/pg_locale.c and src/backend/regex/regc_pg_locale.c match #32 after whitespace normalization.

  • Alexander Kukushkinsaw the final versiontrailerIn #33, he assessed the PostgreSQL 18 backport and explained that a regression test would require a shared_preload_library module.

Sep 2024

7 commits
Remove separate locale_is_c arguments
13 Sep 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #271 of 1 reviewer saw the final version

The like.c and like_match.c changes match #27, including explicit locale arguments to MATCH_LOWER() and GETCHAR().

  • Jeff Davissaw the final versiontrailerHe requested clearer macro data flow in #13 and approved the revised patch in #28.
Simplify checks for deterministic collations.
12 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #241 of 1 reviewer saw the final version

Combines the fourth and fifth patches of #24, removing redundant collate_is_c checks and pg_locale_deterministic(). The additional edit simplifies btvarstrequalimage() to PG_RETURN_BOOL(locale->deterministic).

  • Jeff Davissaw the final versioncommittercommitted the patch
Remove redundant check for default collation.
12 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #241 of 1 reviewer saw the final version

Exactly matches the third patch of #24: removes the DEFAULT_COLLATION_OID alternative from btvarstrequalimage() in src/backend/utils/adt/varlena.c.

  • Jeff Davissaw the final versioncommittercommitted the patch
Remove lc_ctype_is_c().
6 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 98% surepart of a posted patchsetmoderate changesfrom patchset #241 of 2 reviewers saw the final version

Lands the lc_ctype_is_c() removal from the second patch of #24 after its regex error-state cleanup was extracted into 7829f85a62. It also fixes the provider assertion to use the local locale and removes redundant NULL guards in pattern_char_isalpha().

  • Peter Eisentrautsaw an earlier versionLLM analysis, 88% sureHe proposed removing lc_ctype_is_c() and reading locale fields directly in #20, before the attached implementation and subsequent regex changes.
  • Jeff Davissaw the final versioncommittercommitted the patch
Be more careful with error paths in pg_set_regex_collation().
5 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #241 of 1 reviewer saw the final version

The commit explicitly identifies an extraction from Andreas Karlsson's patch, whose latest attachment is #24. It isolates delayed assignment of pg_regex_locale and extends the approach to the strategy and collation globals in pg_set_regex_collation().

  • Jeff Davissaw the final versioncommittercommitted the patch
Remove lc_collate_is_c().
4 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #241 of 2 reviewers saw the final version

Derives from the first patch of #24, with make_greater_string() checking empty strings first, explicit invalid-OID errors, and explicit NULL initialization for C-locale sort support. Jeff explains the error-path changes in #26.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% sureHe proposed removing lc_collate_is_c() and using the cached locale field in #20, before the attached implementation and final invalid-OID handling changes.
  • Jeff Davissaw the final versioncommittercommitted the patch
Remember last collation to speed up collation cache.
3 Sep 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: Speed up collation cache (modified before commit)

Jul - Aug 2024

8 commits
Slightly refactor varstr_sortsupport() to improve readability.
20 Aug 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #221 of 1 reviewer saw the final version

Matches the sixth patch of #22, moving the abbreviation-support check inside the non-C branch of varstr_sortsupport().

  • Jeff Davissaw the final versioncommittercommitted the patch
Remove unnecessary check for NULL locale, per Coverity.
12 Aug 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Removes the single redundant locale NULL guard in Generic_Text_IC_like() identified by Tom Lane in #17 and confirmed unnecessary in #18; no attachment carries this change.

  • Tom Lanesaw the final versionLLM analysis, 99% sureHe reported the Coverity finding and proposed removing the exact redundant guard in #17.
  • Peter Eisentrautsaw the final versionLLM analysis, 100% sureHe confirmed before the commit that the NULL check was no longer necessary in #18.
Remove dead code
12 Aug 2024Peter Eisentrautmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #121 of 1 reviewer saw the final version

Matches the first patch of #12, deleting SB_lower_char()'s obsolete NULL-locale fallback in src/backend/utils/adt/like.c.

  • Jeff Davissaw the final versiontrailerIn #13, he checked the locale argument flow and judged the patches correct while requesting clearer presentation.
selfuncs.c: use pg_strxfrm() instead of strxfrm().
6 Aug 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #10

Matches the third patch of #10 in executable changes, replacing selfuncs.c strxfrm() calls with pg_strxfrm(). The commit additionally updates two nearby comments to name pg_strxfrm().

Remove support for null pg_locale_t most places.
6 Aug 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #100 of 2 reviewers saw the final version

Lands most of the second patch of #10, with comment updates, but omits the wchar2char()/char2wchar() changes and get_db_env_locale() call. Jeff explicitly describes those exclusions in #11.

  • Peter Eisentrautsaw an earlier versiontrailerHe identified missing NULL cleanups in #4 and approved the revised series in #9, before the conversion-function changes were excluded.
  • Andreas Karlssonsaw an earlier versiontrailerHe requested consolidation in #6 and approved the series in #8, before the environment-locale redesign and final scope reduction.
Make collation not depend on setlocale().
30 Jul 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #70 of 2 reviewers saw the final version

Uses the third patch of #7, but corrects the builtin locale assignment from result.collate_is_c to result.ctype_is_c and adds builtin-C regression coverage in collate.utf8.sql and its expected output.

  • Peter Eisentrautsaw an earlier versiontrailerHe reviewed the cache simplification in #4 and reapproved the series in #9, before the builtin ctype flag correction and added tests.
  • Andreas Karlssonsaw an earlier versiontrailerHe reviewed the series in #6 and #8, before the committed builtin ctype flag correction.
Do not return NULL from pg_newlocale_from_collation().
29 Jul 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #72 of 2 reviewers saw the final version

Matches the second patch of #7, including make_libc_collator(), C/POSIX handling, and returning default_locale for the libc database collation.

  • Peter Eisentrautsaw the final versiontrailerHe requested elimination of duplicated initialization in #4 and approved the revised series in #9.
  • Andreas Karlssonsaw the final versiontrailerHe reviewed the revised series and declared it ready for a committer in #8.
Refactor: make default_locale internal to pg_locale.c.
28 Jul 2024Jeff Davismaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #72 of 2 reviewers saw the final version

Uses the first patch of #7, with a small CheckMyDatabase() simplification assigning TextDatumGetCString() directly to locale instead of introducing a temporary datlocale variable.

  • Peter Eisentrautsaw the final versiontrailerHe reviewed initialization naming and documentation in #4 and reported re-reviewing the series in #9, with only light changes to this patch.
  • Andreas Karlssonsaw the final versiontrailerHe proposed delaying the datlocale lookup in #6 and approved the resulting series in #8.

Credits across 16 commits

Author
Andreas Karlsson2 LLM7
Jeff DavisLLM6
Peter EisentrautLLM2
Reviewer
Jeff Daviscommitter9
Andreas Karlsson4
Peter Eisentraut4
Alexander Kukushkin1
Reported by
Alexander Kukushkin1
Tom Lane1
Committer
Jeff Davis14
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.