Mar 2026

3 commits
Replace getopt() with our re-entrant variant in the backend
30 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #51 of 1 reviewer saw the final version

The commit diff exactly matches the third patch in #5, converting bootstrap, postmaster, and backend option parsing and updating src/backend/utils/misc/ps_status.c.

  • Peter Eisentrautsaw the final versiontrailerIn #4, he reviewed #3 and questioned converting bootstrap and postmaster callers; the committed conversion followed only rebase and editorial changes.
Invent a variant of getopt(3) that is thread-safe
30 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #50 of 1 reviewer saw the final version

The commit follows the second patch in #5, but changes pg_getopt_start() in src/port/pg_getopt_ctx.c to initialize opterr to 1 instead of 0. It also documents and relocates the opterr field in src/include/port/pg_getopt_ctx.h and corrects comments and the copyright year.

  • Peter Eisentrautsaw an earlier versiontrailerIn #4, he said the API in #3 looked good, but the default error-reporting behavior changed before commitment without a subsequent review from him in the thread.
Fix latent bug in get_stats_option_name()
30 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #51 of 1 reviewer saw the final version

The commit diff exactly matches the first patch in #5, replacing two references to global optarg with the arg parameter in get_stats_option_name() in src/backend/tcop/postgres.c.

  • Peter Eisentrautsaw the final versiontrailerIn #4, he identified the first patch in #3 as a genuine latent bug worth fixing, and that fix reached the commit unchanged apart from rebasing.

Credits across 3 commits

Author
Heikki LinnakangasLLM3
Reviewer
Peter Eisentraut3
Committer
Heikki Linnakangas3

N LLM means N of the credits come from LLM analysis, not from commit trailers.